Skip to content

Commit

Permalink
disallow fallback to Make in Python builds (#636)
Browse files Browse the repository at this point in the history
Contributes to rapidsai/build-planning#146

Proposes:

* setting `[tool.scikit-build].ninja.make-fallback = false`, so `scikit-build-core` will not silently fallback to using GNU Make if `ninja` is not available
* including all groups in `dependencies.yaml` with `output_types: pyproject` in `output_types: requirements` as well.
  - *So that, for example, they show up in the solved environment in RAPIDS devcontainers (https://github.com/rapidsai/devcontainers)*

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #636
  • Loading branch information
jameslamb authored Feb 3, 2025
1 parent c366d61 commit df4ea06
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ dependencies:
- *libcusparse114
cuda_wheels:
specific:
- output_types: pyproject
- output_types: [requirements, pyproject]
matrices:
- matrix:
cuda: "12.*"
Expand Down
2 changes: 1 addition & 1 deletion python/cuvs/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ build-dir = "build/{wheel_tag}"
cmake.build-type = "Release"
cmake.version = "CMakeLists.txt"
minimum-version = "build-system.requires"
ninja.make-fallback = true
ninja.make-fallback = false
sdist.reproducible = true
wheel.packages = ["cuvs"]

Expand Down
2 changes: 1 addition & 1 deletion python/libcuvs/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ build-dir = "build/{wheel_tag}"
cmake.build-type = "Release"
cmake.version = "CMakeLists.txt"
minimum-version = "build-system.requires"
ninja.make-fallback = true
ninja.make-fallback = false
sdist.reproducible = true
wheel.install-dir = "libcuvs"
wheel.packages = ["libcuvs"]
Expand Down

0 comments on commit df4ea06

Please sign in to comment.