Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use thrust::binary_function anymore #4859

Closed

Conversation

caugonnet
Copy link

@caugonnet caugonnet commented Jan 10, 2025

thrust::binary_function was deprecated in CCCL 2.6 and removed in CCCL 3.0

Closes #4858

Copy link

copy-pr-bot bot commented Jan 10, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@seunghwak
Copy link
Contributor

/okay to test

@seunghwak seunghwak added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 10, 2025
@caugonnet
Copy link
Author

/okay to test

@ChuckHastings
Copy link
Collaborator

/ok to test

@caugonnet caugonnet marked this pull request as ready for review January 21, 2025 17:33
@caugonnet caugonnet requested a review from a team as a code owner January 21, 2025 17:33
@bdice
Copy link
Contributor

bdice commented Jan 21, 2025

/ok to test

1 similar comment
@ChuckHastings
Copy link
Collaborator

/ok to test

@ChuckHastings
Copy link
Collaborator

/merge

@ChuckHastings
Copy link
Collaborator

/ok to test

@ChuckHastings
Copy link
Collaborator

/merge

@bdice
Copy link
Contributor

bdice commented Jan 24, 2025

/ok to test

@ChuckHastings
Copy link
Collaborator

/ok to test

@ChuckHastings
Copy link
Collaborator

Looks like this change is completely included in #4888. Can we close this in favor of 4888?

@caugonnet
Copy link
Author

Sure, i'm closing !

@caugonnet caugonnet closed this Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuGraph improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: cuGraph is using thrust::binary_function which was deprecated in main CCCL's branch
4 participants