-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove docs support in build.sh, remove test_wheel.sh, other small cleanup #60
Conversation
@@ -1,40 +0,0 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexbarghi-nv this looks like it's not used on #53.
I strongly suspect the version here was adopted from https://github.com/rapidsai/cugraph/blob/branch-24.12/ci/test_wheel.sh, which in the cugraph
repo is never used with cugraph-dgl
/ cugraph-pyg
: https://github.com/search?q=repo%3Arapidsai%2Fcugraph%20%22test_wheel.sh%22&type=code
I strongly suspect test_wheel.sh
could just be removed, and that the ci/wheel_smoke_test_${package_name}.py
scripts being proposed on #53 are unnecessary, and covering functionality already covered by the ci/test_wheel_${package_name}.sh
scripts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this can be taken out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I've just pushed changes to #53 removing the smoke-testing stuff that was added there.
@alexbarghi-nv am I right about this PR (that we want to remove docs-building details in this repo)? If so could you approve? Then I can go get a |
We're moving docs into a new repo and not building them here, so that's correct. |
Changes look good, thanks for the clarifying questions above. |
Pulling more changes off of #53, to make that diff smaller and get us closer to having full CI running in this repo.
docs
argument forbuild.sh
(docs building is handled byci/build_docs.sh
)ci/test_wheel.sh
wheel_smoke_test_cugraph.py
(copied over fromcugraph
but not needed here, to be replaced by other scripts you can see in the diff of Add CI for cuGraph-GNN #53)