Convert hex regex patterns to be language-agnostic and fix bad Windows OS catch-all regex #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This regex was really bad and took 20-30 seconds to match in java. After this change it comes down to milliseconds.
jhart-r7
approved these changes
Jun 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As indicated in #138 the use of
\his a special feature of Ruby's regex engine. For other languages and runtimes it causes the matches to fail since it has a different meaning. I replaced all occurrences that I could find.Additionally I fixed the Windows OS catch-all regex which had really bad backtracking performance, especially in Java where it would take 20-30 seconds to match (or not match) for a single string. Since it is super generic anyway I got rid of the attempt at capturing a version for it as well.