Feature/moc #11
Merged
Feature/moc #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jkrasting
commented
Jun 3, 2020
jkrasting
commented
- Initial commit of MOC script
- fixed leftover calls to defunct 'om4analysis'
- common functions still need to be broken out
raphaeldussin
requested changes
Jun 4, 2020
| warnings.filterwarnings("ignore", message=".*dates out of range.*") | ||
|
|
||
|
|
||
| def get_z(ds, depth, var_name): |
There was a problem hiding this comment.
Definitely. Also part of #12.
| return _vh | ||
|
|
||
|
|
||
| def generate_basin_masks(basin_code, basin=None): |
There was a problem hiding this comment.
Definitely. Also part of #12.
raphaeldussin
requested changes
Jun 15, 2020
|
@jkrasting can you pull my changes, add palettable to ci/requirements.txt, re-run black? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.