Fix deprecation warnings (rust 1.51) #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Error, drop the deprecated description() method and move the logic into the Display impl. In bin.rs, use explicit 'dyn' annotation for Boxes of traits. This is functionally identical, but the older syntax is deprecated. In the KAT support logic, the format string of an assert!() must be a string literal in Rust 2021. As the variable we were using for the format string was itself a formatted string, we can just simplify by doing the formatting in assert!() itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Error, drop the deprecated description() method and move the logic
into the Display impl.
In bin.rs, use explicit 'dyn' annotation for Boxes of traits. This is
functionally identical, but the older syntax is deprecated.
In the KAT support logic, the format string of an assert!() must be a
string literal in Rust 2021. As the variable we were using for the
format string was itself a formatted string, we can just simplify by
doing the formatting in assert!() itself.