Backport/FIX: Access Violation in OCB #3924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused an access violation when re-allocating the m_L vector (due to a lazy .push_back()) and invalidating local references in the process. See also randombit#3812 for details.
randombit
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a back port of #3814, in response to the reminder by @ni4. Sorry, again, for that.
Anyway, it turns out, that this bug was actually exposed by this patch during the 3.x development. It reduced the allowed update granularity of the OCB mode, making it much easier to provoke a bogus state of OCB.
Albeit more contrived, its still possible to create an example to hit the access violation in 2.19.4.