Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Coder Partner Chart Addition #1102

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

greg-the-coder
Copy link
Contributor

Updated initial Coder Partner Chart addition: removed coder-provisioner packaged, and updated coder packer/chart with latest marketing feedback.

@greg-the-coder greg-the-coder requested a review from a team as a code owner January 21, 2025 18:07
Copy link
Collaborator

@adamkpickering adamkpickering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, there are just a few things I think could be improved with the wording of app-readme.md.

@@ -0,0 +1,16 @@
# Coder/coder
## Overview
Coder provides development environments in your public and private clouds. Environments are defined with Terraform, connected through a secure high-speed tunnel, and are automatically shut down when not in use to save on costs. Coder gives engineering teams the flexibility to use the cloud for workloads that are most beneficial to them.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I'd remove the "are" from "and are automatically shut down" - its awkward because the previous part of the sentence ("connected through a secure high-speed tunnel") does not have an "are".

## Overview
Coder provides development environments in your public and private clouds. Environments are defined with Terraform, connected through a secure high-speed tunnel, and are automatically shut down when not in use to save on costs. Coder gives engineering teams the flexibility to use the cloud for workloads that are most beneficial to them.

Developers can connect to Coder workspaces the tools and IDEs they know and love including with VS Code Remote, JetBrains Gateway, SSH as well as web IDEs such as JupyterLab, code-server, RStudio, and web terminals.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean "connect to Coder workspaces using the tools and IDEs they know..."?

## Overview
Coder provides development environments in your public and private clouds. Environments are defined with Terraform, connected through a secure high-speed tunnel, and are automatically shut down when not in use to save on costs. Coder gives engineering teams the flexibility to use the cloud for workloads that are most beneficial to them.

Developers can connect to Coder workspaces the tools and IDEs they know and love including with VS Code Remote, JetBrains Gateway, SSH as well as web IDEs such as JupyterLab, code-server, RStudio, and web terminals.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I would remove the "with" in "... and IDEs they know and love including with VS Code Remote..."

adamkpickering
adamkpickering previously approved these changes Jan 22, 2025
@adamkpickering adamkpickering merged commit 747a847 into rancher:main-source Jan 22, 2025
1 check passed
@adamkpickering
Copy link
Collaborator

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants