Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom vendor to managed apps warning messages for delete and upgrade #13198

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

momesgin
Copy link
Member

Summary

Fixes #13126

Technical notes summary

We already had the warning messages in place, this PR adds the vendor to those messages.

Areas or cases that should be tested

I tested this using the test repo provided by Diogo from the Mapps team:

Git Url: https://github.com/diogoasouza/charts
Branch: test-annotation

First case:

  1. Find Istio from the above repo, and install version 105.5.3+up1.24.1(It has catalog.cattle.io/managed set to Flux).
  2. Once installed, go to the Installed Apps page and choose Edit/Upgrade from the action menu for rancher-istio.
  3. Check if Flux is included in the warning message on the installing page.
  4. Go back to the Installed Apps page.
  5. Choose Delete from the action menu.
  6. Check if Flux is included in the warning message on the modal.

Second case:

  1. Go to the Installed Apps page, and find rancher-webhook that is managed by Rancher.
  2. Choose Edit/Upgrade from the action menu.
  3. Check if Rancher is included in the warning message on the installing page.
  4. Go back to the Installed Apps page.
  5. Choose Delete from the action menu.
  6. Check if Rancher is included in the warning message on the modal.

Areas which could experience regressions

n/a

Screenshot/Video

image image

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@momesgin momesgin added this to the v2.11.0 milestone Jan 23, 2025
@momesgin momesgin requested a review from codyrancher January 23, 2025 23:21
@momesgin momesgin self-assigned this Jan 23, 2025
@momesgin momesgin merged commit 5a83e05 into rancher:master Jan 24, 2025
35 checks passed
@momesgin momesgin deleted the 13126-managed-apps-warning-message branch January 24, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change warning message for Managed charts
2 participants