Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for creation of registry secret using RKE auth config type #13153

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

nwmac
Copy link
Member

@nwmac nwmac commented Jan 20, 2025

Summary

Fixes #13116

Technical notes summary

This PR adds support for creation of the rke.cattle.io/auth-config (RKE Auth Config) when setting a secret for the registry configuration on cluster creation.

Note we already showed RKE Auth config secrets in the drop-down, but we did not offer the user the ability to create them from the cluster creation screen - this has now been addded.

The changes are all in the SelectOrCreateAuthSecret component. The remaining code is to add a new E2E test for these changes.

Note the relevant e2e tests are also updated to delete the secrets and clusters that they create.

I also create the grammar on the create labels - I believe it should be 'an' and not 'a' for the options we have.

Areas or cases that should be tested

Cluster creation with registry configuration and RKE auth config secret auth.

Screenshot/Video

New option is added to the drop-down - see below:

image

Checklist

  • [x ] The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Copy link
Member

@eva-vashkevich eva-vashkevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nwmac nwmac merged commit 78c867e into rancher:master Jan 21, 2025
32 checks passed
@nwmac nwmac deleted the fix-registry-rke-auth-config-support branch January 21, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Rancher to provisioning registries.yaml with auth key values instead of username and password
2 participants