-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup and introduce visual testing tools and CI #13035
Open
cnotv
wants to merge
31
commits into
rancher:master
Choose a base branch
from
cnotv:feature/10469-visual-regressions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnotv
force-pushed
the
feature/10469-visual-regressions
branch
from
January 9, 2025 19:25
f38b1ad
to
48151c0
Compare
cnotv
force-pushed
the
feature/10469-visual-regressions
branch
from
January 10, 2025 10:08
3031529
to
b12912d
Compare
…nd ensure screenshot generation
…ut reduced, and disabled animations
cnotv
force-pushed
the
feature/10469-visual-regressions
branch
from
January 10, 2025 12:00
b12912d
to
e967888
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9057
This is an abstract of what I'll present in the demo.
Occurred changes and/or fixed issues
Introduced visual testing which will ensure components do not change styles. The whole process is an E2E test of Cypress running over Storybook.
Every component of our styleguide will be then tested.
Single abstracted views would need to be added in Storybook as sample pages.
Images generated for visual regressions are hosted in this project under
./visual/snapshots
.Technical notes summary
cypress.visual.config.ts
Cypress configuration to run over Storybook./visual
containing all the code, tests, and images for the testsyarn visual
for running the tests in CI; runyarn storybook
prior thisyarn visual:open
for developing mode with head to see the UI; runyarn storybook
prior thisyarn visual:ci
for executing concurrently Storybook and visual tests@emerson-eps/cypress-image-snapshot
, but considering replacing it with single libraries if we rewrite the codeAreas or cases that should be tested
Areas which could experience regressions
New pipeline
Tests / visual-test
should pass.Command
yarn visual
should run the test (run Storybook first).Screenshot/Video
Checklist