Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.9] Align gitlab reusable workflow with release-2.9 #13033

Merged
merged 1 commit into from
Jan 10, 2025
Merged

[2.9] Align gitlab reusable workflow with release-2.9 #13033

merged 1 commit into from
Jan 10, 2025
+3 −3

Conversation

jordojordo
Copy link
Member

@jordojordo jordojordo commented Jan 9, 2025 •
edited
Loading

Summary

This updates the target branch of the reusable workflow within the .gitlab-ci.yml file that is imported into an extension through the creator and ensures we are targeting the correct branch of the workflow file.

Occurred changes and/or fixed issues

  • Bumped yq version v4.4.6
  • Bumped extension creator version 2.0.8

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@jordojordo jordojordo added area/extensions creator PRs/Issues that relate to a creator release rather than being needed for a dashboard release labels Jan 9, 2025
@jordojordo jordojordo requested a review from aalves08 January 9, 2025 18:33
@jordojordo jordojordo self-assigned this Jan 9, 2025
@jordojordo jordojordo added this to the v2.9.6 milestone Jan 9, 2025
@jordojordo jordojordo changed the title Align gitlab reusable workflow with release-2.9 [2.9] Align gitlab reusable workflow with release-2.9 Jan 9, 2025
aalves08
aalves08 approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this update!

@jordojordo jordojordo merged commit e1a6686 into rancher:release-2.9 Jan 10, 2025
33 checks passed
@jordojordo jordojordo deleted the 2.9-ext-gitlab branch January 10, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalves08 aalves08 aalves08 approved these changes

Assignees

@jordojordo jordojordo

Labels
area/extensions creator PRs/Issues that relate to a creator release rather than being needed for a dashboard release
Projects
None yet
Milestone
v2.9.6
Development

Successfully merging this pull request may close these issues.
2 participants
@jordojordo @aalves08