Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-2.9] build-extension-catalog fails #12994

Closed
wants to merge 1 commit into from

Conversation

masap
Copy link
Contributor

@masap masap commented Jan 7, 2025

Summary

Fixes #12993.

Occurred changes and/or fixed issues

Empty tagged_release causes trailing error.

Run yarn parse-tag-name  12645625456 "catalog"
yarn run v1.22.22
warning package.json: No license field
$ ./node_modules/@rancher/shell/scripts/extension/parse-tag-name 12645625456 catalog Parse tag name - evaluating release tag 12645625456 release tag doesn't match any chart tag: 12645625456. Check your pkg/<!-YOUR-EXT-> folders and corresponding versions to complete the match invalid run-id "catalog"
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. error Command failed with exit code 1.
Error: Process completed with exit code 1.

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Resolves rancher#12993.

Empty tagged_release causes trailing error.

Run yarn parse-tag-name  12645625456 "catalog"
yarn run v1.22.22
warning package.json: No license field
$ ./node_modules/@rancher/shell/scripts/extension/parse-tag-name 12645625456 catalog
Parse tag name - evaluating release tag 12645625456
release tag doesn't match any chart tag: 12645625456. Check your pkg/<!-YOUR-EXT-> folders and corresponding versions to complete the match
invalid run-id "catalog"
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
Error: Process completed with exit code 1.

Signed-off-by: Masashi Honma <[email protected]>
Copy link
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checklist needs filling out

@aalves08 same question here, do the builds now reference branches or use a baked in version originating from main? would this change need to go into all branches?

@richard-cox richard-cox requested a review from jordojordo January 7, 2025 07:17
@masap
Copy link
Contributor Author

masap commented Jan 7, 2025

I confirmed master and release-2.8 branch does not have this issue.

@aalves08 aalves08 added this to the v2.9.6 milestone Jan 7, 2025
@aalves08
Copy link
Member

aalves08 commented Jan 7, 2025

I don't know how we've missed this... 🤦 I'll need to add tests for the workflows on the creators. The issue to track it exists already.

It's not the only branch that has problems @masap . In master, for example, we are missing the tagged_release as well.

If you don't mind @masap , I am going to close this PR a create all the PRs needed with the bump of the creators version as well. It all needs to go in so that I can release new versions for each branch.

@richard-cox both shell and creators packages are per branch, meaning that if you create an extension targeting legacy-v1 tag (rancher 2.8.x), https://extensions.rancher.io/extensions/next/extensions-getting-started#creating-an-extension-for-legacy-versions you will get created a system that is reliant on the branch release-2.8, with the necessary compatible files and the workflows that we ship from that creator will target reusable workflows in release-2.8 branch.

Same analogy goes for legacy-v2 tag (rancher 2.9.x) and release-2.9 branch + latest tag (rancher 2.10.x and above) and master branch

@aalves08 aalves08 closed this Jan 7, 2025
@masap
Copy link
Contributor Author

masap commented Jan 7, 2025

If you don't mind @masap , I am going to close this PR a create all the PRs needed with the bump of the creators version as well. It all needs to go in so that I can release new versions for each branch.

Ok, no problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants