-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e test that creates GKE cluster with default settings #12934
Open
IsaSih
wants to merge
4
commits into
master
Choose a base branch
from
gke-po
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-cox
requested changes
Dec 23, 2024
cypress/e2e/tests/pages/manager/gke-cluster-provisioning.spec.ts
Outdated
Show resolved
Hide resolved
richard-cox
reviewed
Jan 2, 2025
7 tasks
Signed-off-by: Isabela Guimaraes <[email protected]>
Signed-off-by: Isabela Guimaraes <[email protected]>
…oud credentials Signed-off-by: Isabela Guimaraes <[email protected]>
Signed-off-by: Isabela Guimaraes <[email protected]>
@richard-cox could you please give an update on the review? Thanks |
richard-cox
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Occurred changes and/or fixed issues
This PR addresses the issue rancher/qa-tasks#1571.
This is a single e2e test that creates a GKE cluster with the default settings and verifies that the cluster is created and that the GKE default version and zone are displayed in the UI elements as expected. To support the test, were created GKE-related page objects for the GKE Create cloud credentials page, the GKE authenticate page with Project ID, and the Create GKE Cluster Page.
Some methods and variables were created but are not being used in this single test. Still, they will be used for the upcoming tests.
Storing the GKE Cloud credentials will be addressed in another PR.
Areas or cases that should be tested
Create a GKE Cluster with default settings
Other cluster provisioning-related tests
Other cloud credentials creation related tests
Other pages that contain LabeledInput or LabeledSelect elements
Areas which could experience regressions
other cluster provisioning tests
Checklist