Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: api_key and basic_auth security scheme support #134

Merged

Conversation

floydspace
Copy link
Collaborator

@floydspace floydspace commented Nov 11, 2024

🚨 Please review the guidelines for contributing to this repository.

Add support for the missing security schemes

  • apiKey - maps to apy_key wso2 api definition
  • basicAuth - maps to basic_auth wso2 api definition
image

⬇️

image
  • Updated unit tests (*.spec.js)
  • Updated e2e tests (here)
  • Updated documentation (here)

🙌 Thank you!

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.63%. Comparing base (e4bb55b) to head (0c46940).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
src/3.2.0/wso2apim.js 83.33% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #134      +/-   ##
==========================================
- Coverage   81.64%   81.63%   -0.02%     
==========================================
  Files           3        3              
  Lines         594      599       +5     
  Branches       74       76       +2     
==========================================
+ Hits          485      489       +4     
- Misses         95       96       +1     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@diego-antonelli diego-antonelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent change! Gonna release this morning

@diego-antonelli diego-antonelli merged commit 0163ccd into main Nov 12, 2024
5 checks passed
@diego-antonelli diego-antonelli deleted the feature/apiKey-and-basicAuth-securityScheme-support branch November 12, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants