Add support for immutable timestamps (#43)

* Test if SEOData class can handle immutable timestamps * Add CarbonInterface as typehint to allow both immutable and mutable objects --------- Co-authored-by: Stan Daniëls <[email protected]>
ralphjsmit · Aug 12, 2023 · e1769c1 · e1769c1
1 parent 2788725
commit e1769c1
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 6 deletions.
diff --git a/src/Schema/ArticleSchema.php b/src/Schema/ArticleSchema.php
@@ -2,17 +2,17 @@
 
 namespace RalphJSmit\Laravel\SEO\Schema;
 
-use Illuminate\Support\Carbon;
+use Carbon\CarbonInterface;
 use Illuminate\Support\Collection;
 use RalphJSmit\Laravel\SEO\Support\SEOData;
 
 class ArticleSchema extends Schema
 {
     public array $authors = [];
 
-    public ?Carbon $datePublished = null;
+    public ?CarbonInterface $datePublished = null;
 
-    public ?Carbon $dateModified = null;
+    public ?CarbonInterface $dateModified = null;
 
     public ?string $description = null;
 

diff --git a/src/Support/SEOData.php b/src/Support/SEOData.php
@@ -2,7 +2,7 @@
 
 namespace RalphJSmit\Laravel\SEO\Support;
 
-use Carbon\Carbon;
+use Carbon\CarbonInterface;
 use Illuminate\Support\Str;
 use RalphJSmit\Helpers\Laravel\Pipe\Pipeable;
 use RalphJSmit\Laravel\SEO\SchemaCollection;
@@ -19,8 +19,8 @@ public function __construct(
         public ?string $url = null,
         public bool $enableTitleSuffix = true,
         public ?ImageMeta $imageMeta = null,
-        public ?Carbon $published_time = null,
-        public ?Carbon $modified_time = null,
+        public ?CarbonInterface $published_time = null,
+        public ?CarbonInterface $modified_time = null,
         public ?string $articleBody = null,
         public ?string $section = null,
         public ?array $tags = null,

diff --git a/tests/Unit/Models/SEOTest.php b/tests/Unit/Models/SEOTest.php
@@ -1,5 +1,7 @@
 <?php
 
+use Carbon\CarbonImmutable;
+use Illuminate\Support\Facades\Date;
 use RalphJSmit\Laravel\SEO\Models\SEO;
 use RalphJSmit\Laravel\SEO\Support\SEOData;
 use RalphJSmit\Laravel\SEO\Tests\Fixtures\Page;
@@ -22,6 +24,16 @@
     expect($export)->toBeInstanceOf(SEOData::class);
 });
 
+it('can have immutable timestamps', function () {
+    Date::useClass(CarbonImmutable::class);
+
+    $seo = Page::create()->seo;
+
+    $export = $seo->prepareForUsage();
+
+    expect($export)->toBeInstanceOf(SEOData::class);
+});
+
 it('can add properties to a SEO model', function (string $property, string $input) {
     $page = Page::create();