refactor: fetch RMCSDK version from plist only once form RMC Bundle (…

…SDKCF-6851)

Sources/REventLogger/REvent.swift

@@ -56,14 +56,14 @@ struct REvent: Codable, Equatable {
         self.deviceModel = environment.deviceModel
         self.deviceBrand = environment.deviceBrand
         self.deviceName = environment.deviceName
+        self.rmcSdks = environment.rmcSDKs
         self.firstOccurrenceOn = Date().timeIntervalSince1970
         self.eventType = eventType
         self.sourceName = sourceName
         self.sourceVersion = sourceVersion
         self.errorCode = errorCode
         self.errorMessage = errorMessage
         self.info = info
-        self.rmcSdks = Bundler.rmcSdks
     }
 }
 

Sources/REventLogger/REventLoggerEnvironment.swift

@@ -8,10 +8,13 @@ private enum BundleKeys {
     static let bundleIdentifier = "CFBundleIdentifier"
     static let shortVersion = "CFBundleShortVersionString"
     static let displayName = "CFBundleDisplayName"
+    static let rmcBundleName = "RMC_RMC.bundle"
+    static let rmcVersionsInfoList = "RmcInfo"
 }
 
 final class REventLoggerEnvironment {
     private let bundle: BundleProtocol
+    private var rmcSDKsVersion: [String: String]?
 
     init(bundle: BundleProtocol = Bundle.main) {
         self.bundle = bundle
@@ -49,26 +52,25 @@ final class REventLoggerEnvironment {
         bundle.deviceBrand()
     }
 
-    var rmcBundle: Bundle? {
-        .rmcResources
+    var rmcSDKs: [String: String]? {
+        if rmcSDKsVersion == nil {
+            rmcSDKsVersion = getRMCSDKsVersion()
+        }
+        return rmcSDKsVersion
     }
 
-    var rmcSdks: [String: String]? {
-        rmcBundle?.getRMCSdks()
+    private func getRMCSDKsVersion() -> [String: String]? {
+        guard let path = Bundle.rmcBundle?.path(forResource: BundleKeys.rmcVersionsInfoList, ofType: "plist") else { return nil }
+        return NSDictionary(contentsOfFile: path) as? [String: String]
     }
 }
 
-internal extension Bundle {
-    static var rmcResources: Bundle? {
-        guard let rmcBundleUrl = main.resourceURL?.appendingPathComponent("RMC_RMC.bundle"),
+extension Bundle {
+    static var rmcBundle: Bundle? {
+        guard let rmcBundleUrl = main.resourceURL?.appendingPathComponent(BundleKeys.rmcBundleName),
               let bundle = Bundle(url: rmcBundleUrl) else {
             return nil
         }
         return bundle
     }
-
-    fileprivate func getRMCSdks() -> [String: String]? {
-        guard let path = path(forResource: "RmcInfo", ofType: "plist") else { return nil }
-        return NSDictionary(contentsOfFile: path) as? [String: String]
-    }
 }

Sources/REventLogger/Utilities/Utility.swift

@@ -56,7 +56,3 @@ extension NSError {
         self.code == URLError.networkConnectionLost.rawValue
     }
 }
-
-enum Bundler {
-    static let rmcSdks = REventLoggerEnvironment().rmcSdks
-}