Add backlog parameter to the listen method #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backlog is a TCP protocol parameter determining how many unaccepted connections the kernel will keep in a queue before refusing new connections. IO::Socket::Async already supported the parameter, so only forwarding the parameter was necessary.
|
Wow. That was fast. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backlog is a TCP protocol parameter determining how many unaccepted connections the kernel will keep in a queue before refusing new connections. IO::Socket::Async already supported the parameter, so only forwarding the parameter was necessary.
I believe this is the last bit of ground work for the IO::Socket::SSL look-alike on top of IO::Socket::Async::SSL that I'm working on. I named it IO::Socket::TLSViaAsync. It's mostly done, but not on the ecosystem yet.
Also, once this is merged, can you make a release allowing me to use this (and the other already merged PR).