-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using checkpoints for a single workflow #95
Open
danilexn
wants to merge
130
commits into
rajewsky-lab:fast-cmdline
Choose a base branch
from
danilexn:fast-cmdline-danilexn-checkpoints
base: fast-cmdline
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Using checkpoints for a single workflow #95
danilexn
wants to merge
130
commits into
rajewsky-lab:fast-cmdline
from
danilexn:fast-cmdline-danilexn-checkpoints
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
… (triggered in minimal data testing)
…t for DGE (probably ancient bead-related feature) which fails with newer pandas anyway.
…actually completes
Removing defaults channel
…ashing. Also black formatting
…'default' which also exists in 0.7.9 config.yaml
…. Needs proper resource handling in the future
…e 4MB as long as we do not properly treat it as a resource
…ecting my own mistake)
After long testing and many bugfixes we now have a new 0.8 candidate with this branch. In agreement with Dani and Nikos, I merge this PR into master.
After merging with current |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I adapted the workflow so it only needs to call a single
target
rule, using checkpoints.I have tested with the (tiny) test data and some real mouse brain samples - with and without spatial pucks, with and without puck collection, with and without meshing. Tests were run for the main, merging and downsampling workflows.
Important: I have tested all with snakemake 7.32.4. Previous versions (especially 5.x-6.x) might not work - workflow stops unexpectedly with apparently no error.
To be done before merging:
obs
do not haven_joined
, and order of columns is different). I am fixing this.