Add test for copyto! with start indices and for dims tuple in similar #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The error seems to be a CondaPkg problem and unrelated to my change |
|
@JamesWrigley can you look at this? It makes me somewhat nervous being close to pythons dumpster fire of dependency management. We may need to drop it from tests? |
|
I also ran into this recently: JuliaLang/IJulia.jl#1145 (comment) EDIT: see #936. |
|
Ok @felixcremer you can update against main and this should pass |
felixcremer
force-pushed
the
fc/testcopyto
branch
from
d79a745 to
5762fd1
Compare
|
I just force pushed a rebased version. Let's see where the tests are going to fail now. |
rafaqz
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests for copyto! with an start index for the source and the destination.
It also adds a test case for similar with a tuple of dims.