Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend DiskArrays.pad #931

Merged
merged 8 commits into from
Mar 7, 2025
Merged

extend DiskArrays.pad #931

merged 8 commits into from
Mar 7, 2025

Conversation

rafaqz
Copy link
Owner

@rafaqz rafaqz commented Feb 20, 2025

This PR extends the new DiskArrays.pad for all AbstractDimArray so we can also extend regular dimensions at the same time we pad the array.

I'm not sure what should happen for non DiskArrays parent arrays - currently they will work but be slow. Using PaddedViews.j instead is an option when !isdisk(parent(dimarray)).

See DiskArrays PR: JuliaIO/DiskArrays.jl#219

@rafaqz rafaqz closed this Mar 7, 2025
@rafaqz rafaqz reopened this Mar 7, 2025
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 83.87097% with 5 lines in your changes missing coverage. Please review.

Project coverage is 84.30%. Comparing base (a5585f5) to head (76c28f2).
Report is 35 commits behind head on main.

Files with missing lines Patch % Lines
ext/DimensionalDataDiskArraysExt.jl 83.87% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #931      +/-   ##
==========================================
+ Coverage   83.66%   84.30%   +0.63%     
==========================================
  Files          47       52       +5     
  Lines        4653     4893     +240     
==========================================
+ Hits         3893     4125     +232     
- Misses        760      768       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rafaqz rafaqz merged commit 8811bba into main Mar 7, 2025
9 of 10 checks passed
@rafaqz rafaqz deleted the da_pad branch March 7, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant