Expose securified security state and expose methods that relied on unsecured entity control on hosts #375

micbakos-rdx · 2025-02-07T12:09:59Z

Export a method that checks if an account is legacy olympia.
Export a method that returns the unsecured controlling factor instance for accounts and personas.
The BDFS error check, as discussed, is not needed so I removed the implementation I temporarily wrote in sargon.
Expose secured entity control to hosts.

codecov · 2025-02-07T12:26:51Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.68%. Comparing base (d3a9f85) to head (f99d389).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #375      +/-   ##
==========================================
+ Coverage   92.64%   92.68%   +0.03%     
==========================================
  Files        1180     1184       +4     
  Lines       26658    26689      +31     
  Branches       77       85       +8     
==========================================
+ Hits        24698    24737      +39     
+ Misses       1949     1941       -8     
  Partials       11       11

Flag	Coverage Δ
kotlin	`98.86% <100.00%> (+1.23%)`	⬆️
rust	`92.27% <100.00%> (-0.04%)`	⬇️
swift	`92.87% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CyonAlexRDX · 2025-02-07T12:38:22Z

crates/profile/logic/logic_SPLIT_ME/src/logic/account/account_is_legacy.rs

+
+impl AccountIsLegacyOlympia for Account {
+    fn is_legacy_olympia(&self) -> bool {
+        let Some(unsecured_entity_control) = self.security_state.as_unsecured()


You can just self.address.is_legacy()

CyonAlexRDX · 2025-02-07T12:40:02Z

crates/profile/logic/logic_SPLIT_ME/src/logic/account/account_is_unsecured_ledger_controlled.rs

+}
+
+impl EntityUnsecuredControllingFactorInstance for Account {
+    fn unsecured_controlling_factor_instance(


I want to avoid this.

Why are we adding it?

Temporarily as part of a process of transitioning?

As so said the other day, I don't want hosts to concern themselves with FactorInstances / PublicKeys at all

Temporarily as part of a process of transitioning?

Yes exactly for this reason. The refactoring effort is too much for now.

GhenadieVP · 2025-02-07T13:20:39Z

crates/uniffi/uniffi_SPLIT_ME/src/profile/v100/entity_security_state/entity_security_state.rs

@@ -23,8 +27,10 @@ impl From<InternalEntitySecurityState> for EntitySecurityState {
                    value: value.into(),
                }
            }
-            InternalEntitySecurityState::Securified { value: _ } => {
-                panic!("Securified state not yet supported in the Wallet")
+            InternalEntitySecurityState::Securified { value } => {


With this added you should be able to use InternalConversion macro on EntitySecurityState

Right will do

micbakos-rdx · 2025-02-07T14:25:30Z

Will keep this PR open until iOS host integrates with it.

…me exposed method for legacy olympia

micbakos-rdx added Rust 🦀 Changes in Rust Sargon Kotlin 🤖 Changes in Kotlin Sargon UniFFI 🦄 Changes in UniFFI exported APIs labels Feb 7, 2025

micbakos-rdx requested review from CyonAlexRDX, GhenadieVP, giannis-rdx, danvleju-rdx, sergiupuhalschi-rdx and matiasbzurovski February 7, 2025 12:09

micbakos-rdx self-assigned this Feb 7, 2025

micbakos-rdx changed the title ~~Expose securified security state and expose methods that relied on unsecurified security state on hosts~~ Expose securified security state and expose methods that relied on unsecured entity control on hosts Feb 7, 2025

CyonAlexRDX requested changes Feb 7, 2025

View reviewed changes

CyonAlexRDX approved these changes Feb 7, 2025

View reviewed changes

GhenadieVP reviewed Feb 7, 2025

View reviewed changes

GhenadieVP approved these changes Feb 7, 2025

View reviewed changes

GhenadieVP mentioned this pull request Feb 7, 2025

Sargon SecurityState update radixdlt/babylon-wallet-ios#1458

Merged

micbakos-rdx added 12 commits February 10, 2025 12:31

Export is legacy olympia for account

37ffbb8

Export methods for ledger backed accounts

04fb378

WIP

36485fb

Replace with unsecured_controlling_factor_instance

d0cae56

Remove unnecessary check for BDFS error

89934a0

Expose SecuredEntityControl

a54b2dc

Expose sample for InternalSecurityStructureOfFactorInstances and rena…

b2ee975

…me exposed method for legacy olympia

Use InternalConversion for EntitySecurityState

c50c2d5

Fix swift tests

f23c145

Fix test

f2d7247

Remove unused hasAuthenticationSigningKey

7c40dde

micbakos-rdx added 3 commits February 10, 2025 12:31

Reformat

2e611a2

Add missing unit tests that caused coverage to dip

9378266

micbakos-rdx force-pushed the mib/ABW-4155-remove-usages-security-state-host branch from 216549b to f99d389 Compare February 10, 2025 10:32

GhenadieVP approved these changes Feb 10, 2025

View reviewed changes

micbakos-rdx merged commit a18623a into main Feb 10, 2025
13 checks passed

micbakos-rdx deleted the mib/ABW-4155-remove-usages-security-state-host branch February 10, 2025 13:06

micbakos-rdx mentioned this pull request Feb 10, 2025

Remove direct usages of Unsecured security state radixdlt/babylon-wallet-android#1325

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Expose securified security state and expose methods that relied on unsecured entity control on hosts #375

Expose securified security state and expose methods that relied on unsecured entity control on hosts #375

micbakos-rdx commented Feb 7, 2025

codecov bot commented Feb 7, 2025 •

edited

Loading

CyonAlexRDX Feb 7, 2025

CyonAlexRDX Feb 7, 2025

micbakos-rdx Feb 7, 2025

GhenadieVP Feb 7, 2025 •

edited

Loading

micbakos-rdx Feb 7, 2025

micbakos-rdx commented Feb 7, 2025

Expose securified security state and expose methods that relied on unsecured entity control on hosts #375

Expose securified security state and expose methods that relied on unsecured entity control on hosts #375

Conversation

micbakos-rdx commented Feb 7, 2025

codecov bot commented Feb 7, 2025 • edited Loading

Codecov Report

CyonAlexRDX Feb 7, 2025

Choose a reason for hiding this comment

CyonAlexRDX Feb 7, 2025

Choose a reason for hiding this comment

micbakos-rdx Feb 7, 2025

Choose a reason for hiding this comment

GhenadieVP Feb 7, 2025 • edited Loading

Choose a reason for hiding this comment

micbakos-rdx Feb 7, 2025

Choose a reason for hiding this comment

micbakos-rdx commented Feb 7, 2025

codecov bot commented Feb 7, 2025 •

edited

Loading

GhenadieVP Feb 7, 2025 •

edited

Loading