[DO-000] use specific artifact name to download it

[duje-begonja-rdx]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.68%. Comparing base (a18623a) to head (b5fb0fe).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #370   +/-   ##
=======================================
  Coverage   92.68%   92.68%           
=======================================
  Files        1184     1184           
  Lines       26689    26689           
  Branches       85       85           
=======================================
  Hits        24737    24737           
  Misses       1941     1941           
  Partials       11       11           

Flag	Coverage Δ
kotlin	98.86% <ø> (ø)
rust	92.27% <ø> (ø)
swift	92.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Sajjon]

should this really be x86_64-unknown-linux-gnu but the one above is aarch64-apple-darwin ? looks wrong with the assymetry?

[micbakos-rdx]

In summary:

The upload-artifact job was uploading the artifacts and was renaming them to the target triple's name:
Upload from:

path: target/x86_64-unknown-linux-gnu/release/libsargon_uniffi.so
name: x86_64-unknown-linux-gnu

AND

path: target/aarch64-apple-darwin/release/libsargon_uniffi.dylib
name: aarch64-apple-darwin

This still works as it used to, but, inn the past the download-artifact job we used, was downloading each artifact and when unwrapping it was also naming it with the name of the directory it was saved into. So

// It used to be like this
artifacts/x86_64-unknown-linux-gnu/libsargon_uniffi.so
artifacts/aarch64-apple-darwin/libsargon_uniffi.dylib

// Now changed to
artifacts/libsargon_uniffi.dylib
artifacts/libsargon_uniffi.so

So gradle's scripts could not pick up the correct files. It seems that the latest main of the download job is unwrapping in place without extracting the binaries in their respective directory