Remove duplicate fsi assert from veci

[sergiupuhalschi-rdx]

Remove the assert of address and factor instance derivation path discrepancies from VirtualEntityCreatingInstance ctor non-debug code. If we identify a discrepancy, we log it with error!.

[Sajjon]

This fn has an incorrect name. It sgould be check_for_derivation_path_discrepancies or similar

[Sajjon]

Furthemore you can maybe put a debug_assertion gated behind #[cfg(test)] in the body

[Sajjon]

    fn check_for_derivation_path_discrepancies(
        factor_instance: &HierarchicalDeterministicFactorInstance,
        address: &AddressOfAccountOrPersona,
    ) {
       let discrepancy_found = factor_instance.derivation_path().get_entity_kind()
            == address.get_entity_kind();
       let error_msg = "Discrepancy! Address and DerivationPath of FactorInstances have different entity kinds.";
        if discrepancy_found
        {
            error!(error_msg);
        }
            #[cfg(test]
            debug_assert!(!discrepancy_found, error_msg)
    }

with formatting... :D

[sergiupuhalschi-rdx]

Although I was close to getting it right, I think your comment saved me from another round of changes :)) Thanks!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.64%. Comparing base (56196a5) to head (88d3d82).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #366      +/-   ##
==========================================
+ Coverage   92.61%   92.64%   +0.03%     
==========================================
  Files        1180     1180              
  Lines       26658    26658              
  Branches       77       77              
==========================================
+ Hits        24690    24698       +8     
+ Misses       1957     1949       -8     
  Partials       11       11              

Flag	Coverage Δ
kotlin	97.63% <ø> (ø)
rust	92.31% <100.00%> (+0.03%)	⬆️
swift	92.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Sajjon]

it should be != and not == right?.

Missing unit tests as well :)

[sergiupuhalschi-rdx]

Isn't this unit test enough?

[Sajjon]

I realize it was ME who accidentally gave you == :D :D sorry about that

and yes, sorry I was accidentally checking only last commit... that test is fine!

[sergiupuhalschi-rdx]

No worries, I should have double-checked. Thanks for spotting this!