Expose make interaction for applying shields function #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micbakos-rdx
added
Rust 🦀
micbakos-rdx
force-pushed
the
mib/prepare-for-batch-transactions
branch
from
306db51 to
bf788d9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #364 +/- ##
=======================================
Coverage 92.63% 92.63%
=======================================
Files 1177 1177
Lines 26572 26566 -6
Branches 77 77
=======================================
- Hits 24614 24609 -5
+ Misses 1947 1946 -1
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CyonAlexRDX
approved these changes
Jan 30, 2025
| // TODO change when queue is introduced | ||
| // `CannotSecurifyEntityHasProvisionalSecurityConfig` should be returned when | ||
| // 1. entity's shield is in provisional state | ||
| // 2. interaction is in the queue. |
There was a problem hiding this comment.
When 1. AND 2. Right? I think an update to the comment stating the Boolean AND make it more clear
| CommonError::CannotSecurifyEntityHasProvisionalSecurityConfig, | ||
| ); | ||
| } | ||
| // if !entities.iter().all(|a| a.get_provisional().is_none()) { |
There was a problem hiding this comment.
I would copy paste the comment above here too, explaining why code is commented out
[email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] Generated by cargo-workspaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CannotSecurifyEntityHasProvisionalSecurityConfigis not returned when provisional shield is in place since this error should be thrown when a provisional shield exists for that entity but there is also a pending transaction in the queue.Not authorizing the set metadata update ends in the following error