Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create WalletToDappInteractionAuthProof on Sargon #360

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

matiasbzurovski
Copy link
Contributor

@matiasbzurovski matiasbzurovski commented Jan 28, 2025

Changelog

Move to Sargon the creation of WalletToDappInteractionAuthProof (used when signing auth) so that it isn't Hosts responsibility to decide which curve to use.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.59%. Comparing base (860b5f2) to head (0454ba1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #360   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files        1170     1172    +2     
  Lines       26248    26255    +7     
  Branches       81       81           
=======================================
+ Hits        24305    24312    +7     
  Misses       1932     1932           
  Partials       11       11           
Flag Coverage Δ
kotlin 97.73% <100.00%> (+<0.01%) ⬆️
rust 92.20% <100.00%> (+<0.01%) ⬆️
swift 93.03% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Sajjon Sajjon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@matiasbzurovski matiasbzurovski merged commit 3634378 into main Jan 29, 2025
13 checks passed
@matiasbzurovski matiasbzurovski deleted the mb/move-logic-from-host branch January 29, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants