Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Shield Wallet Interaction Part 2 #355

Merged
merged 28 commits into from
Jan 29, 2025

Release 1.1.123

0de346a
Select commit
Loading
Failed to load commit list.
Merged

Apply Shield Wallet Interaction Part 2 #355

Release 1.1.123
0de346a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 29, 2025 in 0s

92.65% (+0.05%) compared to 3634378

View this Pull Request on Codecov

92.65% (+0.05%) compared to 3634378

Details

Codecov Report

Attention: Patch coverage is 93.75000% with 19 lines in your changes missing coverage. Please review.

Project coverage is 92.65%. Comparing base (3634378) to head (0de346a).

Files with missing lines Patch % Lines
...rc/apply_security_shield/sargon_os_apply_shield.rs 85.18% 4 Missing ⚠️
...eld/manifests_securify_shield_securified_entity.rs 91.11% 4 Missing ⚠️
...shield/access_controller_factors_and_time_input.rs 85.71% 3 Missing ⚠️
.../models/supporting-types/src/securified_persona.rs 66.66% 2 Missing ⚠️
...exercisable_in_transaction_manifest_combination.rs 95.74% 2 Missing ⚠️
...urity_shield/top_up_access_controller_xrd_vault.rs 91.66% 2 Missing ⚠️
...ces_structures/matrices/builder/matrix_template.rs 75.00% 1 Missing ⚠️
...structures/matrices/matrix_of_factor_source_ids.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #355      +/-   ##
==========================================
+ Coverage   92.59%   92.65%   +0.05%     
==========================================
  Files        1172     1181       +9     
  Lines       26255    26628     +373     
  Branches       81       81              
==========================================
+ Hits        24312    24673     +361     
- Misses       1932     1944      +12     
  Partials       11       11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov