[ABW-4135] Export method to derive public keys #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crates/uniffi/uniffi_SPLIT_ME/src/system/sargon_os/sargon_os_derive_public_keys.rs
Outdated
Show resolved
Hide resolved
matiasbzurovski
force-pushed
the
ABW-4135-derive-public-keys
branch
from
1a8e46d to
e9f57e4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #350 +/- ##
==========================================
- Coverage 92.68% 92.57% -0.11%
==========================================
Files 1166 1169 +3
Lines 26084 26143 +59
Branches 81 81
==========================================
+ Hits 24175 24202 +27
- Misses 1898 1930 +32
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
matiasbzurovski
force-pushed
the
ABW-4135-derive-public-keys
branch
from
e9f57e4 to
5b9a9b1
Compare
| /// | ||
| /// # Emits Event | ||
| /// Emits `Event::ProfileModified { change: EventProfileModified::PersonaAdded }` | ||
| pub async fn create_and_save_new_persona_with_bdfs( |
There was a problem hiding this comment.
Maybe rename it to _main_bdfs
| /// | ||
| /// # Emits Event | ||
| /// Emits `Event::ProfileModified { change: EventProfileModified::AccountAdded }` | ||
| pub async fn create_and_save_new_account_with_bdfs( |
There was a problem hiding this comment.
Maybe rename it to _main_bdfs
matiasbzurovski
changed the title
matiasbzurovski
force-pushed
the
ABW-4135-derive-public-keys
branch
from
5877c75 to
2b47db8
Compare
matiasbzurovski
commented
Jan 23, 2025
Comment on lines
-103
to
-106
| /// Checks if it is Main Babylon Device Factor Source (BDFS). | ||
| pub fn is_main_bdfs(&self) -> bool { | ||
| self.supports_babylon() && self.is_main() | ||
| } |
There was a problem hiding this comment.
As discussed on latest design session, this check shouldn't be part of FactorSourceCommon, since it only matters for DeviceFactorSource. The logic in such file has been updated to check what we were previously delegating here.
micbakos-rdx
approved these changes
Jan 23, 2025
matiasbzurovski
force-pushed
the
ABW-4135-derive-public-keys
branch
from
6bfb375 to
e5e23f8
Compare
[email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] Generated by cargo-workspaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA ticket: ABW-4135
Changelog
HostInteractor.bdfstomain_bdfs.Notes
A lot of the file diff comes from the latest change mentioned, so you may want to review that commit independently. You can review the 16 previous commits here.