Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish early mono sign when skipping factor #342

Merged
merged 11 commits into from
Jan 20, 2025

Remove simulated skips from main tests

c3fdaf8
Select commit
Loading
Failed to load commit list.
Merged

Finish early mono sign when skipping factor #342

Remove simulated skips from main tests
c3fdaf8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 20, 2025 in 1s

92.84% (+0.00%) compared to eca2370

View this Pull Request on Codecov

92.84% (+0.00%) compared to eca2370

Details

Codecov Report

Attention: Patch coverage is 87.09677% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.84%. Comparing base (eca2370) to head (c3fdaf8).

Files with missing lines Patch % Lines
.../app/signing/src/collector/signatures_collector.rs 75.00% 4 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #342   +/-   ##
=======================================
  Coverage   92.84%   92.84%           
=======================================
  Files        1160     1160           
  Lines       25797    25815   +18     
  Branches       85       85           
=======================================
+ Hits        23952    23969   +17     
- Misses       1834     1835    +1     
  Partials       11       11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov