Fix swift tests

radixdlt · Feb 7, 2025 · 3727177 · 3727177
1 parent a60d216
commit 3727177
Show file tree

Hide file tree

Showing 5 changed files with 28 additions and 16 deletions.
diff --git a/...s/Sargon/Extensions/Swiftified/Profile+Supporting+Types/AccountOrPersona+Swiftified.swift b/...s/Sargon/Extensions/Swiftified/Profile+Supporting+Types/AccountOrPersona+Swiftified.swift
@@ -83,6 +83,12 @@ extension AccountOrPersona: EntityBaseProtocol {
 			\.virtualHierarchicalDeterministicFactorInstances
 		)
 	}
+
+	public var unsecuredControllingFactorInstance: SargonUniFFI.HierarchicalDeterministicFactorInstance? {
+		property(
+			\.unsecuredControllingFactorInstance
+		)
+	}
 }
 
 extension AccountOrPersona {

diff --git a/apple/Sources/Sargon/Extensions/Swiftified/Profile/Account/Account+Swiftified.swift b/apple/Sources/Sargon/Extensions/Swiftified/Profile/Account/Account+Swiftified.swift
@@ -7,6 +7,10 @@ extension Account: EntityBaseProtocol {
 	public var asGeneral: AccountOrPersona {
 		.account(self)
 	}
+
+	public var unsecuredControllingFactorInstance: SargonUniFFI.HierarchicalDeterministicFactorInstance? {
+		accountUnsecuredControllingFactorInstance(account: self)
+	}
 }
 
 extension Account {

diff --git a/apple/Sources/Sargon/Extensions/Swiftified/Profile/Persona/Persona+Swiftified.swift b/apple/Sources/Sargon/Extensions/Swiftified/Profile/Persona/Persona+Swiftified.swift
@@ -8,6 +8,10 @@ extension Persona: EntityBaseProtocol {
 	public var asGeneral: AccountOrPersona {
 		.persona(self)
 	}
+
+	public var unsecuredControllingFactorInstance: SargonUniFFI.HierarchicalDeterministicFactorInstance? {
+		personaUnsecuredControllingFactorInstance(persona: self)
+	}
 }
 
 // MARK: - Persona + EntityProtocol

diff --git a/apple/Sources/Sargon/Protocols/EntityProtocol.swift b/apple/Sources/Sargon/Protocols/EntityProtocol.swift
@@ -20,6 +20,7 @@ public protocol EntityBaseProtocol: BaseBaseEntityProtocol, CustomStringConverti
 	var securityState: EntitySecurityState { get }
 	var entityKind: EntityKind { get }
 	var asGeneral: AccountOrPersona { get }
+	var unsecuredControllingFactorInstance: HierarchicalDeterministicFactorInstance? { get }
 
 	#if DEBUG
 	static var sampleMainnet: Self { get }
@@ -47,30 +48,29 @@ extension EntityBaseProtocol {
 		Set<HierarchicalDeterministicFactorInstance>
 	{
 		var factorInstances = Set<HierarchicalDeterministicFactorInstance>()
-		switch securityState {
-		case let .unsecured(unsecuredEntityControl):
-			factorInstances.insert(unsecuredEntityControl.transactionSigning)
-			return factorInstances
+
+		if let unsecuredControllingFactorInstance {
+			factorInstances.insert(unsecuredControllingFactorInstance)
 		}
+
+		return factorInstances
 	}
 
 	public var hasAuthenticationSigningKey: Bool {
 		switch securityState {
 		case .unsecured:
 			false
+		case .securified(value: _):
+			false
 		}
 	}
 
 	public var deviceFactorSourceID: FactorSourceIDFromHash? {
-		switch self.securityState {
-		case let .unsecured(control):
-			let factorSourceID = control.transactionSigning.factorSourceID
-			guard factorSourceID.kind == .device else {
-				return nil
-			}
-
-			return factorSourceID
+		guard let factorSourceId = unsecuredControllingFactorInstance?.factorSourceId, factorSourceId.kind == .device else {
+			return nil
 		}
+
+		return factorSourceId
 	}
 }
 

diff --git a/apple/Tests/Utils/EntityProtocolTest.swift b/apple/Tests/Utils/EntityProtocolTest.swift
@@ -72,10 +72,8 @@ class EntityBaseTest<SUT_: EntityBaseProtocol>: Test<SUT_> {
 				case .ed25519: break // good
 				case .secp256k1: XCTFail("Wrong key kind")
 				}
-				// TODO: Handle
-				//			case .securified(value: _):
-				//				XCTFail("Wrong security state")
-				//			}
+			case .securified(value: _):
+				XCTFail("Wrong security state")
 			}
 		}
 	}