[ABW-4080] Shields List + Change main shield #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d230b5f.
matiasbzurovski
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
LGTM, but given radixdlt/sargon#374 is already approved maybe worth waiting for it and remove the TODOs
| if case let .selection(isSelected) = mode { | ||
| RadioButton( | ||
| appearance: .dark, | ||
| state: isSelected ? .selected : .unselected |
There was a problem hiding this comment.
minor: we do this in a lot of places, might as well have an init that takes a isSelected: Bool instead
| } | ||
|
|
||
| // MARK: - ShieldCardStatus | ||
| // TODO: define in Sargon ------------------ |
There was a problem hiding this comment.
put inside MoveToSargon folder?
There was a problem hiding this comment.
This will be handled soon, so it’s fine to leave it here for now
GhenadieVP
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: ABW-4080
Changelog
Video
video