-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fixes for long-running tests #8680
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: willdavsmith <[email protected]>
Signed-off-by: willdavsmith <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8680 +/- ##
=======================================
Coverage 59.88% 59.89%
=======================================
Files 596 596
Lines 40512 40512
=======================================
+ Hits 24261 24264 +3
+ Misses 14423 14422 -1
+ Partials 1828 1826 -2 ☔ View full report in Codecov by Sentry. |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we spent time investigating it before marking it skipped? If we are skipping the test, can you make sure that a task to unskip it is created and assigned as well?
Signed-off-by: willdavsmith <[email protected]>
Signed-off-by: willdavsmith <[email protected]>
Test_TerraformRecipe_KubernetesPostgres
@@ -49,13 +49,16 @@ fi | |||
|
|||
# Delete all test namespaces. | |||
echo "delete all test namespaces" | |||
namespaces=$(kubectl get namespace | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO this system is too complicated. Instead I think it's better to specify the namespaces we want to keep and delete everything else. Looks like there's already been some discussion about this: #7966
@@ -90,7 +90,7 @@ module aksCluster './modules/akscluster.bicep' = { | |||
params: { | |||
name: aksClusterName | |||
location: location | |||
kubernetesVersion: '1.28.5' | |||
kubernetesVersion: '1.31.5' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was unable to run this bicep deployment locally because of the outdated kubernetes version. This should make sure that next time we create a long-running test cluster we won't hit this issue.
Description
Type of change
Fixes: #issue_number
Contributor checklist
Please verify that the PR meets the following requirements, where applicable: