Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes for long-running tests #8680

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

willdavsmith
Copy link
Contributor

@willdavsmith willdavsmith commented Feb 26, 2025

Description

Type of change

  • This pull request fixes a bug in Radius and has an approved issue (issue link required).
  • This pull request adds or changes features of Radius and has an approved issue (issue link required).
  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
    • Yes
    • Not applicable
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
    • Yes
    • Not applicable
  • The design document has been reviewed and approved by Radius maintainers/approvers.
    • Yes
    • Not applicable
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
    • Yes
    • Not applicable
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
    • Yes
    • Not applicable
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
    • Yes
    • Not applicable

Signed-off-by: willdavsmith <[email protected]>
lakshmimsft
lakshmimsft previously approved these changes Feb 26, 2025
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.89%. Comparing base (bbb1d24) to head (066a530).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8680   +/-   ##
=======================================
  Coverage   59.88%   59.89%           
=======================================
  Files         596      596           
  Lines       40512    40512           
=======================================
+ Hits        24261    24264    +3     
+ Misses      14423    14422    -1     
+ Partials     1828     1826    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sk593
sk593 previously approved these changes Feb 26, 2025
@radius-functional-tests
Copy link

radius-functional-tests bot commented Feb 26, 2025

Radius functional test overview

🔍 Go to test action run

Name Value
Repository willdavsmith/radius
Commit ref 5d176de
Unique ID funca7508d9228
Image tag pr-funca7508d9228
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funca7508d9228
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funca7508d9228
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funca7508d9228
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funca7508d9228
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funca7508d9228
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ corerp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded

Copy link
Contributor

@kachawla kachawla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we spent time investigating it before marking it skipped? If we are skipping the test, can you make sure that a task to unskip it is created and assigned as well?

Signed-off-by: willdavsmith <[email protected]>
Signed-off-by: willdavsmith <[email protected]>
@willdavsmith willdavsmith changed the title Skipping failing test: Test_TerraformRecipe_KubernetesPostgres Various fixes for long-running tests Mar 1, 2025
@@ -49,13 +49,16 @@ fi

# Delete all test namespaces.
echo "delete all test namespaces"
namespaces=$(kubectl get namespace |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this system is too complicated. Instead I think it's better to specify the namespaces we want to keep and delete everything else. Looks like there's already been some discussion about this: #7966

@@ -90,7 +90,7 @@ module aksCluster './modules/akscluster.bicep' = {
params: {
name: aksClusterName
location: location
kubernetesVersion: '1.28.5'
kubernetesVersion: '1.31.5'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was unable to run this bicep deployment locally because of the outdated kubernetes version. This should make sure that next time we create a long-running test cluster we won't hit this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants