Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating VALID_RADIUS_BUILD_WINDOW to 30 mins #8387

Conversation

vishwahiremat
Copy link
Contributor

Description

Updating VALID_RADIUS_BUILD_WINDOW to 30 mins to trigger long running tests to pick the new build for testing failures.

Type of change

  • This pull request fixes a bug in Radius and has an approved issue (issue link required).
  • This pull request adds or changes features of Radius and has an approved issue (issue link required).
  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
    • Yes
    • Not applicable
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
    • Yes
    • Not applicable
  • The design document has been reviewed and approved by Radius maintainers/approvers.
    • Yes
    • Not applicable
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
    • Yes
    • Not applicable
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
    • Yes
    • Not applicable
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
    • Yes
    • Not applicable

@vishwahiremat vishwahiremat requested review from a team as code owners January 30, 2025 21:35
@vishwahiremat vishwahiremat changed the title Ppdating VALID_RADIUS_BUILD_WINDOW to 30 mins Updating VALID_RADIUS_BUILD_WINDOW to 30 mins Jan 30, 2025
@lakshmimsft
Copy link
Contributor

Approving - Temporary Update for testing

@radius-functional-tests
Copy link

radius-functional-tests bot commented Jan 30, 2025

Radius functional test overview

🔍 Go to test action run

Name Value
Repository vishwahiremat/radius
Commit ref f2861de
Unique ID func3953b592ec
Image tag pr-func3953b592ec
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func3953b592ec
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func3953b592ec
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func3953b592ec
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func3953b592ec
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func3953b592ec
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@vishwahiremat vishwahiremat merged commit 8e6d5ff into radius-project:main Jan 30, 2025
25 checks passed
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.94%. Comparing base (f9226de) to head (f2861de).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8387   +/-   ##
=======================================
  Coverage   59.94%   59.94%           
=======================================
  Files         596      596           
  Lines       40432    40432           
=======================================
  Hits        24235    24235           
  Misses      14369    14369           
  Partials     1828     1828           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants