Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove skipped test #6998

Merged
merged 3 commits into from
Jan 8, 2024
Merged

Remove skipped test #6998

merged 3 commits into from
Jan 8, 2024

Conversation

kachawla
Copy link
Contributor

@kachawla kachawla commented Jan 6, 2024 •
edited
Loading

Description

Test_AWSRedeployWithCreateAndWriteOnlyPropertyUpdate requires #6227 to be implemented. Removing this test until the feature is implemented. Adding this and other feature specific tests should be a part of the overall feature plan.

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #6949

@kachawla
Remove skipped test
8fad71b 
Signed-off-by: karishma-chawla <[email protected]>
@kachawla kachawla requested a review from willdavsmith January 6, 2024 02:57
@kachawla kachawla requested review from a team as code owners January 6, 2024 02:57
@kachawla kachawla force-pushed the kachawla/functional-test branch from 4962f1b to 8fad71b Compare January 6, 2024 02:58
@kachawla kachawla temporarily deployed to functional-tests January 6, 2024 03:01 — with GitHub Actions Inactive
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jan 6, 2024 •
edited
Loading

Radius functional test overview

🔍 Go to test action run

Name Value
Repository kachawla/radius
Commit ref 656c2af
Unique ID b5c561742d
Image tag pr-b5c561742d
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-b5c561742d
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-b5c561742d
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-b5c561742d
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-b5c561742d
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting daprrp functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting samples functional tests...
⌛ Starting shared functional tests...
⌛ Starting msgrp functional tests...
✅ ucp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ samples functional tests succeeded
✅ msgrp functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

ytimocin
ytimocin approved these changes Jan 6, 2024
View reviewed changes
Copy link
Contributor

@ytimocin ytimocin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this test be a part of the feature stated in the description of this PR? If so, does the engineer who will work on it need to know this test?

@kachawla
Copy link
Contributor Author

kachawla commented Jan 8, 2024

Will this test be a part of the feature stated in the description of this PR? If so, does the engineer who will work on it need to know this test?

I think it should be covered as a part of test/development plan for the feature. I'm not sure if this test as is will be applicable anymore since it was written a while ago, so an explicit reference to this test shouldn't be necessary I think.

@kachawla kachawla temporarily deployed to functional-tests January 8, 2024 17:00 — with GitHub Actions Inactive
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jan 8, 2024 •
edited
Loading

Radius functional test overview

🔍 Go to test action run

Name Value
Repository kachawla/radius
Commit ref 5158203
Unique ID d4df7b4dbf
Image tag pr-d4df7b4dbf
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-d4df7b4dbf
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-d4df7b4dbf
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-d4df7b4dbf
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-d4df7b4dbf
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting shared functional tests...
⌛ Starting msgrp functional tests...
✅ ucp functional tests succeeded
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ kubernetes functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

@kachawla kachawla merged commit 16011a5 into radius-project:main Jan 8, 2024
16 checks passed
willdavsmith pushed a commit to willdavsmith/radius that referenced this pull request Jan 17, 2024
@kachawla @willdavsmith
Remove skipped test (radius-project#6998)
0ca3e6d 
# Description

[Test_AWSRedeployWithCreateAndWriteOnlyPropertyUpdate](https://github.com/radius-project/radius/blob/main/test/functional/shared/mechanics/aws_mechanics_test.go#L96)
requires radius-project#6227 to be
implemented. Removing this test until the feature is implemented. Adding
this and other feature specific tests should be a part of the overall
feature plan.

## Type of change

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->

- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(issue link optional).

<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Fixes: radius-project#6949

Signed-off-by: karishma-chawla <[email protected]>
Co-authored-by: karishma-chawla <[email protected]>
Signed-off-by: willdavsmith <[email protected]>
@kachawla kachawla deleted the kachawla/functional-test branch February 8, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ytimocin ytimocin ytimocin approved these changes

@willdavsmith willdavsmith willdavsmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review and Remove or Enable Skipped Functional Test: Test_AWSRedeployWithCreateAndWriteOnlyPropertyUpdate
3 participants
@kachawla @ytimocin @willdavsmith