Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace issue templates with forms #6982

Merged
merged 6 commits into from
Jan 13, 2024
Merged

chore: replace issue templates with forms #6982

merged 6 commits into from
Jan 13, 2024

Conversation

lechnerc77
Copy link
Contributor

Description

This PR contains a proposal for the migration of the issue templates from markdown to form-based to improve the usability for reporters. For details and screenshots of the layout, please check issue #6981

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #6981

Auto-generated summary

copilot:all

@lechnerc77 lechnerc77 requested review from a team as code owners December 29, 2023 11:21
@rynowak
Copy link
Contributor

rynowak commented Dec 31, 2023

Hi @lechnerc77 - thanks for trying this out. I hope you don't mind if we put this on pause for a week or so to give folks a chance to discuss. Most of the team is celebrating the holidays right now.

This mostly affects the people who review and prioritize incoming issues so I want to make sure they can give their input.

@lechnerc77
Copy link
Contributor Author

@rynowak all fine, I would not have expected any feedback in the holiday season.

@lechnerc77
chore: refinement of required fields
38d58e1 
Signed-off-by: Christian Lechner <[email protected]>
@lechnerc77 lechnerc77 mentioned this pull request Jan 5, 2024
Closed
lechnerc77 and others added 2 commits January 11, 2024 10:49
@lechnerc77 @AaronCrawfis
chore: change rad version input to textarea
63c4564 
Co-authored-by: Aaron Crawfis <[email protected]>
Signed-off-by: Christian Lechner <[email protected]>
@lechnerc77 @AaronCrawfis
fix: change input to text area for system information
04ef0ec 
Co-authored-by: Aaron Crawfis <[email protected]>
Signed-off-by: Christian Lechner <[email protected]>
@lechnerc77
Copy link
Contributor Author

@AaronCrawfis thanks for your suggestions. I added them to the PR.

AaronCrawfis
AaronCrawfis approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@AaronCrawfis AaronCrawfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank! I checked out the experience over at https://github.com/lechnerc77/radius/tree/chore/issue-forms/.github/ISSUE_TEMPLATE and they all look great

@lechnerc77
Copy link
Contributor Author

@AaronCrawfis anything else you need from my side efore you can merge the PR?

@rynowak
Copy link
Contributor

rynowak commented Jan 13, 2024

@AaronCrawfis anything else you need from my side efore you can merge the PR?

I'll help get this merged.

@rynowak rynowak temporarily deployed to functional-tests January 13, 2024 17:42 — with GitHub Actions Inactive
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jan 13, 2024 •
edited
Loading

Radius functional test overview

🔍 Go to test action run

Name Value
Repository lechnerc77/radius
Commit ref 40f3360
Unique ID 308c68d134
Image tag pr-308c68d134
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-308c68d134
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-308c68d134
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-308c68d134
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-308c68d134
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting kubernetes functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting samples functional tests...
⌛ Starting ucp functional tests...
✅ msgrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ samples functional tests succeeded
✅ ucp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ daprrp functional tests succeeded
✅ shared functional tests succeeded

@rynowak rynowak merged commit 21b25dd into radius-project:main Jan 13, 2024
16 checks passed
@rynowak
Copy link
Contributor

rynowak commented Jan 13, 2024

Thanks @lechnerc77 !

willdavsmith pushed a commit to willdavsmith/radius that referenced this pull request Jan 17, 2024
@lechnerc77 @AaronCrawfis
@rynowak @willdavsmith
chore: replace issue templates with forms (radius-project#6982)
d4820a7 
# Description

This PR contains a proposal for the migration of the issue templates
from markdown to form-based to improve the usability for reporters. For
details and screenshots of the layout, please check issue radius-project#6981

## Type of change

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->

- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(issue link optional).

<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Fixes: radius-project#6981

## Auto-generated summary

<!--
GitHub Copilot for docs will auto-generate a summary of the PR
-->

copilot:all

---------

Signed-off-by: Christian Lechner <[email protected]>
Co-authored-by: Aaron Crawfis <[email protected]>
Co-authored-by: Ryan Nowak <[email protected]>
Signed-off-by: willdavsmith <[email protected]>
@lechnerc77 lechnerc77 deleted the chore/issue-forms branch January 24, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rynowak rynowak rynowak approved these changes

@AaronCrawfis AaronCrawfis AaronCrawfis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue reporting - usage of issue forms
3 participants
@lechnerc77 @rynowak @AaronCrawfis