-
Notifications
You must be signed in to change notification settings - Fork 100
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update Terraform Azure Test Resource Type (#8254)
# Description We have been seeing flakyness in terraform recipe azure storage test due to fluctuating create latencies of azure storage account provisioning causing subsequent requests on the resource to fail due to 409. Since the main goal of this test is to validate that Azure provider/auth is correctly configured for Terraform recipes, we don't specifically need to provision Azure storage. So switching the test to create a resource group, which will provision faster for reliability in testing. More details and investigation on this are logged in the comments here: #8237. ## Type of change Fixes: #8172 ## Contributor checklist Please verify that the PR meets the following requirements, where applicable: - [NA] An overview of proposed schema changes is included in a linked GitHub issue. - [NA] A design document PR is created in the [design-notes repository](https://github.com/radius-project/design-notes/), if new APIs are being introduced. - [NA] If applicable, design document has been reviewed and approved by Radius maintainers/approvers. - [NA] A PR for the [samples repository](https://github.com/radius-project/samples) is created, if existing samples are affected by the changes in this PR. - [NA] A PR for the [documentation repository](https://github.com/radius-project/docs) is created, if the changes in this PR affect the documentation or any user facing updates are made. - [NA] A PR for the [recipes repository](https://github.com/radius-project/recipes) is created, if existing recipes are affected by the changes in this PR. Signed-off-by: Karishma Chawla <[email protected]>
- Loading branch information
Showing
6 changed files
with
27 additions
and
52 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
terraform { | ||
required_providers { | ||
azurerm = { | ||
source = "hashicorp/azurerm" | ||
version = "~> 3.114.0" | ||
} | ||
} | ||
} | ||
|
||
resource "azurerm_resource_group" "test_rg" { | ||
name = var.name | ||
location = var.location | ||
} |
2 changes: 1 addition & 1 deletion
2
...raform-recipes/azure-storage/variables.tf → ...t-terraform-recipes/azure-rg/variables.tf
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
variable "resource_group_name" { | ||
variable "name" { | ||
type = string | ||
} | ||
|
||
|
32 changes: 0 additions & 32 deletions
32
test/testrecipes/test-terraform-recipes/azure-storage/main.tf
This file was deleted.
Oops, something went wrong.
5 changes: 0 additions & 5 deletions
5
test/testrecipes/test-terraform-recipes/azure-storage/output.tf
This file was deleted.
Oops, something went wrong.