nit comments

Signed-off-by: sk593 <[email protected]>
radius-project · Aug 7, 2024 · a19a136 · a19a136
1 parent 81dde46
commit a19a136
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 13 deletions.
diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
@@ -289,9 +289,11 @@ jobs:
           if-no-files-found: error
       - name: 'Login via Azure CLI'
         if: github.repository == 'radius-project/radius' && ((startsWith(github.ref, 'refs/tags/v') || github.ref == 'refs/heads/main'))
-        uses: azure/login@v1
+        uses: azure/login@v2
         with:
-          creds: ${{ secrets.BICEP_TYPES_AZURE_CREDENTIALS }}
+          client-id: ${{ secrets.BICEPTYPES_CLIENT_ID }}
+          tenant-id: ${{ secrets.BICEPTYPES_TENANT_ID }}
+          subscription-id: ${{ secrets.BICEPTYPES_SUBSCRIPTION_ID }}
       - name: Setup and verify bicep CLI
         if: github.repository == 'radius-project/radius' && ((startsWith(github.ref, 'refs/tags/v') || github.ref == 'refs/heads/main'))
         run: |

diff --git a/.github/workflows/functional-test-cloud.yaml b/.github/workflows/functional-test-cloud.yaml
@@ -373,13 +373,15 @@ jobs:
       - name: Upload Radius Bicep types artifacts
         uses: actions/upload-artifact@v4
         with:
-          name: radius-bicep-types
+          name: ${{ matrix.name }}_radius_bicep_types
           path: ./hack/bicep-types-radius/generated
           if-no-files-found: error
       - name: 'Login via Azure CLI'
-        uses: azure/login@v1
+        uses: azure/login@v2
         with:
-          creds: ${{ secrets.BICEP_TYPES_AZURE_CREDENTIALS }}
+          client-id: ${{ secrets.BICEPTYPES_CLIENT_ID }}
+          tenant-id: ${{ secrets.BICEPTYPES_TENANT_ID }}
+          subscription-id: ${{ secrets.BICEPTYPES_SUBSCRIPTION_ID }}
       - name: Setup and verify bicep CLI
         run: |
           curl -Lo bicep https://github.com/Azure/bicep/releases/latest/download/bicep-linux-x64

diff --git a/.github/workflows/functional-test-noncloud.yaml b/.github/workflows/functional-test-noncloud.yaml
@@ -127,8 +127,7 @@ jobs:
           # Set output variables to be used in the other jobs
           echo "REL_VERSION=pr-${UNIQUE_ID}" >> $GITHUB_OUTPUT
           echo "DE_IMAGE=${{ env.DE_IMAGE }}" >> $GITHUB_OUTPUT
-          echo "DE_TAG=${{ env.DE_TAG }}" >> $GITHUB_OUTPUT
-          
+          echo "DE_TAG=${{ env.DE_TAG }}" >> $GITHUB_OUTPUT    
   tests:
     name: Run ${{ matrix.name }} functional tests
     needs: build
@@ -222,7 +221,7 @@ jobs:
       - name: Upload Radius Bicep types artifacts
         uses: actions/upload-artifact@v4
         with:
-          name: radius-bicep-types
+          name: ${{ matrix.name }}_radius_bicep_types
           path: ./hack/bicep-types-radius/generated
           if-no-files-found: error       
 

diff --git a/.github/workflows/validate-bicep.yaml b/.github/workflows/validate-bicep.yaml
@@ -23,6 +23,9 @@ on:
       - main
       - release/*
 
+permissions:
+  id-token: write # Required for requesting the JWT
+
 concurrency:
   # Cancel the previously triggered build for only PR build.
   group: bicep-${{ github.event.pull_request.number || github.sha }}
@@ -33,19 +36,20 @@ jobs:
     name: Validate Bicep Code
     runs-on: ubuntu-latest
     steps:
+      - name: Check out repo
+        uses: actions/checkout@v4
       - name: Setup and verify bicep CLI
         run: |
           curl -Lo bicep https://github.com/Azure/bicep/releases/latest/download/bicep-linux-x64
           chmod +x ./bicep
           sudo mv ./bicep /usr/local/bin/bicep
           bicep --version
-      - name: Check out repo
-        uses: actions/checkout@v4
       - name: 'Login via Azure CLI'
-        if: github.repository == 'radius-project/radius' && ((startsWith(github.ref, 'refs/tags/v') || github.ref == 'refs/heads/main'))
         uses: azure/login@v2
         with:
-          creds: ${{ secrets.BICEP_TYPES_AZURE_CREDENTIALS }}
+          client-id: ${{ secrets.BICEPTYPES_CLIENT_ID }}
+          tenant-id: ${{ secrets.BICEPTYPES_TENANT_ID }}
+          subscription-id: ${{ secrets.BICEPTYPES_SUBSCRIPTION_ID }}
       - name: Verify Bicep files
         run: ./build/validate-bicep.sh
         env:

diff --git a/.vscode/launch.json b/.vscode/launch.json
@@ -88,7 +88,7 @@
             },
         },
         {
-            "name": "Debug Jest Tests",
+            "name": "Debug Bicep generator integration tests",
             "type": "node",
             "request": "launch",
             "runtimeArgs": [