addressing comments

Signed-off-by: Vishwanath Hiremath <[email protected]>
radius-project · Jul 25, 2024 · 6c60fb1 · 6c60fb1
1 parent 0a0b08e
commit 6c60fb1
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/pkg/cli/cmd/credential/credential.go b/pkg/cli/cmd/credential/credential.go
@@ -47,7 +47,7 @@ rad credential register azure sp --client-id <client id> --client-secret <client
 rad credential register azure wi --client-id <client id> --tenant-id <tenant id>
 # Register (Add or update) cloud provider credential for AWS with access key authentication.
 rad credential register aws access-key --access-key-id <access-key-id> --secret-access-key <secret-access-key>
-# Register (Add or update) cloud provider credential for AWS with IRSA.
+# Register (Add or update) cloud provider credential for AWS with IRSA (IAM Roles for Service Accounts).
 rad credential register aws irsa --iam-role <roleARN>
 
 # Show cloud provider credential details for Azure

diff --git a/pkg/cli/cmd/credential/register/aws/accesskey/accesskey.go b/pkg/cli/cmd/credential/register/aws/accesskey/accesskey.go
@@ -135,9 +135,8 @@ func (r *Runner) Validate(cmd *cobra.Command, args []string) error {
 // Run runs the `rad credential register aws access-key` command.
 //
 
-// Run() registers an AWS credential with the given context and workspace, and returns an error if unsuccessful.
+// Run registers an AWS credential with the given context and workspace, and returns an error if unsuccessful.
 func (r *Runner) Run(ctx context.Context) error {
-
 	r.Output.LogInfo("Registering credential for %q cloud provider in Radius installation %q...", "aws", r.Workspace.FmtConnection())
 	client, err := r.ConnectionFactory.CreateCredentialManagementClient(ctx, *r.Workspace)
 	if err != nil {

diff --git a/pkg/cli/cmd/credential/register/register.go b/pkg/cli/cmd/credential/register/register.go
@@ -41,8 +41,8 @@ rad credential register azure sp --client-id <client id> --client-secret <client
 rad credential register azure wi --client-id <client id> --tenant-id <tenant id>
 # Register (Add or update) cloud provider credential for AWS with access key authentication.
 rad credential register aws access-key --access-key-id <access-key-id> --secret-access-key <secret-access-key>
-# Register (Add or update) cloud provider credential for AWS with IRSA.
-rad credential register aws irsa --iam-role <roleARN>	
+# Register (Add or update) cloud provider credential for AWS with IRSA (IAM Roles for service Accounts).
+rad credential register aws irsa --iam-role <roleARN>
 `,
 	}