Skip to content

Commit

Permalink
Update devcontainer publishing path (#6967)
Browse files Browse the repository at this point in the history
# Description

This updates the devcontainer publishing path to (hopefully):

```
ghcr.io/radius-project/devcontainer-features/radcli:latest
```

This matches the container that everyone seems to be following at:
https://containers.dev/collections

In particular I don't want the repo name to be part of the path, because
we will probably change repos in the future.

## Type of change

- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(issue link optional).


Part of: #6923

## Auto-generated summary

<!--
GitHub Copilot for docs will auto-generate a summary of the PR
-->

copilot:all

Signed-off-by: Ryan Nowak <[email protected]>
  • Loading branch information
rynowak authored Dec 18, 2023
1 parent 5a53736 commit 4eff028
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
5 changes: 5 additions & 0 deletions .github/workflows/devcontainer-feature-release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@ jobs:
generate-docs: "false"
# disable validation due to used preview feature
disable-schema-validation: "true"
# We handle tagging ourselves
disable-repo-tagging: "true"
# We don't want to include the repo name, being consistent without
# examples at https://containers.dev/collections
features-namespace: "devcontainer-features"

env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
6 changes: 3 additions & 3 deletions deploy/devcontainer-feature/src/radcli/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ This will install the latest stable release of the `rad` CLI.

```json
"features": {
"ghcr.io/devcontainers/radius/radiuscli:latest": {
"ghcr.io/radius-project/devcontainer-features/radcli:latest": {
"version": "latest"
}
}
Expand All @@ -20,7 +20,7 @@ This will install the edge (unstable) release of the `rad` CLI.

```json
"features": {
"ghcr.io/devcontainers/radius/radiuscli:latest": {
"ghcr.io/radius-project/devcontainer-features/radcli:latest": {
"version": "edge"
}
}
Expand All @@ -32,7 +32,7 @@ This will install version 0.28.0 of the `rad` CLI.

```json
"features": {
"ghcr.io/devcontainers/radius/radiuscli:latest": {
"ghcr.io/radius-project/devcontainer-features/radcli:latest": {
"version": "0.28.0"
}
}
Expand Down

0 comments on commit 4eff028

Please sign in to comment.