Merge pull request #103 from radiovisual/invalid-url-handling

Fix: incomplete iframe src url throws error
radiovisual · Aug 19, 2022 · 65c082c · 65c082c
2 parents 1d5667d + 75af5cc
commit 65c082c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/__tests__/index.test.js b/__tests__/index.test.js
@@ -13,4 +13,6 @@ test('returns null as id and service', () => {
 		service: null,
 	};
 	expect(fn('foo')).toMatchObject(expected);
+	expect(fn('<iframe')).toMatchObject(expected);
+	expect(fn('')).toMatchObject(expected);
 });
diff --git a/__tests__/utils/get-src.test.js b/__tests__/utils/get-src.test.js
@@ -29,6 +29,7 @@ describe('get-src', () => {
 
 	test('returns undefined when no src= is found', () => {
 		expect(fn('hello')).toBe(undefined);
+		expect(fn('<iframe')).toBe(undefined);
 	});
 
 	test('single quotes return undefined', () => {

diff --git a/src/index.js b/src/index.js
@@ -20,7 +20,7 @@ function getVideoId(urlString) {
 	let string_ = urlString;
 
 	if (/<iframe/gi.test(string_)) {
-		string_ = getSrc(string_);
+		string_ = getSrc(string_) || '';
 	}
 
 	// Remove surrounding whitespaces or linefeeds