Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add trash startup process and delay. add utility helper. #247

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dabat
Copy link

@dabat dabat commented Jul 22, 2021

hello @rNeomy

first, thank you for your work on this helpful and well-designed application!

while investigating #243, i found that some tabs do not retain their discarded state between restarts of the browser, and this was causing those tabs to never be removed by the trash process.

because the trash alarm is only querying for discarded tabs, some tabs were not being collected, and then were being assigned a new trash timeout--which means that they would not be removed as expected.

this pull-request fixes #243 by adding a trash startup process that discards inactive, undiscarded tabs before the trash alarm process runs.

i tested this on Brave and Firefox and all seems to be working.

i apologize for the formatting changes, the formatting setup on my machine 'cleaned things up'. 😁

please review the changes and let me know what you think.
thank you,
daniel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Permanently delete old discarded tabs if they are inactive option not working on Brave Browser
1 participant