add trash startup process and delay. add utility helper. #247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hello @rNeomy
first, thank you for your work on this helpful and well-designed application!
while investigating #243, i found that some tabs do not retain their discarded state between restarts of the browser, and this was causing those tabs to never be removed by the trash process.
because the trash alarm is only querying for discarded tabs, some tabs were not being collected, and then were being assigned a new trash timeout--which means that they would not be removed as expected.
this pull-request fixes #243 by adding a trash startup process that discards inactive, undiscarded tabs before the trash alarm process runs.
i tested this on Brave and Firefox and all seems to be working.
i apologize for the formatting changes, the formatting setup on my machine 'cleaned things up'. 😁
please review the changes and let me know what you think.
thank you,
daniel