feat(mainnet): add gov: collective, membership, motion #448

peterwht · 2025-01-23T16:56:05Z

[This is a spike and an incomplete PR. But the governance is implemented and can be used]

Adds a Council based governance that:

Has NO elections (selected councillors, to start)
Uses pallet-motion to allow council to use Root origin

To familiarize yourself with this governance mechanism, please use the following guide.

Guide

Goal Checklist

Create a Motion that requires Root

Launch chain pop up parachain -f networks/mainnet.toml
Navigate to Council page and note Members
Navigate to sub-page for Motions
Press "Propose Motion"
Min threshold is currently 1/2 + 1. I recommend setting threshold to 4 (unanimous)
Set the proposal call to motion.unanimous, providing Root origin
Set the sub-call to something that requires Root. One recommendation is to use balances.forceSetBalance
You will see a council.Proposed event
On the Motions page you will see a new Motion available for vote, along with proposal info
Press the Vote button and vote AYE. Repeat this with 4 dev accounts
After the threshold is surpassed, the Vote button now changes to Close. Press this button and submit. The proposal is now passed! You will see several events such as council.voted, council.Approved, council.Executed

Create a Motion that adds a member

Navigate to the Motions page
Press Propose motion
Set threshold 4 (more realistic)
Select councilMembership.addMember for proposal (we do NOT need to use pallet-motion for this). Note, do not use council to set members.
Add Eve or Ferdie (or other as you please)
Press Propose
Go through the voting process and execute the proposal
Wait a bit and refresh the council page. You should now see a new member added that can propose motions and vote.

Create a Motion that removes a member

Navigate to the Motions page
Press Propose motion
Set threshold 4 (more realistic)
Select councilMembership.removeMember for proposal (we do NOT need to use pallet-motion for this). Note, do not use council to set members.
Add Eve or Ferdie (or other as you please)
Press Propose
Go through the voting process and execute the proposal
Wait a bit and refresh the council page. You should now see one less member.

Notes

One important thing to confirm for ANY governance we choose: do we have to pay DOT to propose a runtime upgrade. This can be costly if so.

peterwht · 2025-01-23T16:56:57Z

node/src/chain_spec.rs

@@ -189,7 +189,7 @@ pub fn mainnet_chain_spec(relay: Relay) -> MainnetChainSpec {
 	)
 	.with_name("Pop Network")
 	.with_id("pop")
-	.with_chain_type(ChainType::Live)
+	.with_chain_type(ChainType::Development)


temporary change for better dev account support.

peterwht · 2025-01-23T16:58:22Z

runtime/mainnet/src/config/governance.rs

+}
+
+impl pallet_membership::Config<pallet_membership::Instance1> for Runtime {
+	type AddOrigin = MoreThanHalfCouncil;


recommend we make several of these configs Super Majority (2/3 or 3/4). We can't do unanimous for removing members as the removed member probably wouldn't vote AYE.

peterwht · 2025-01-23T16:59:05Z

runtime/mainnet/src/config/governance.rs

+	type SimpleMajorityOrigin =
+		pallet_collective::EnsureProportionMoreThan<AccountId, CouncilCollective, 1, 2>;
+	type SuperMajorityOrigin =
+		pallet_collective::EnsureProportionAtLeast<AccountId, CouncilCollective, 2, 3>;


recommend we remove these two origins and force unanimous if we want to use Root.

This makes sense to me.

peterwht · 2025-01-23T17:27:59Z

[sc-2571]

al3mart · 2025-01-24T13:41:47Z

Polakdot js apps seems to crash after inputting an external motion 😓 with the expectation of pallet_democracy being present ?

For the record the call I noted as a preimage was balances.forceSetBalance.

I'd assume this is expected as the runtime doesn't feature a way for non council members to cast votes. I think the app will have just wrapped the noted call as a democracy call.
Though is just ugly that the app presents that message.

al3mart

The inclusion of these seemed like a sensible choice. Provides a little better UX for the accounts voting on the motions.

Also seems more flexible looking ahead.

al3mart · 2025-01-24T14:02:50Z

runtime/mainnet/src/config/governance.rs

+}
+
+impl pallet_membership::Config<pallet_membership::Instance1> for Runtime {
+	type AddOrigin = MoreThanHalfCouncil;


Seems that AddOrigin should be configured to be unanimous.

al3mart · 2025-01-24T14:04:04Z

runtime/mainnet/src/config/governance.rs

+	type MaxMembers = CouncilMaxMembers;
+	type MembershipChanged = Council;
+	type MembershipInitialized = Council;
+	type PrimeOrigin = MoreThanHalfCouncil;


PrimeOrigin should be configured to the closest ratio equivalent to all votes in favor but one.

al3mart · 2025-01-24T14:04:19Z

runtime/mainnet/src/config/governance.rs

+	type MembershipChanged = Council;
+	type MembershipInitialized = Council;
+	type PrimeOrigin = MoreThanHalfCouncil;
+	type RemoveOrigin = MoreThanHalfCouncil;


Same as above

al3mart · 2025-01-24T14:04:57Z

runtime/mainnet/src/config/governance.rs

+	type MembershipInitialized = Council;
+	type PrimeOrigin = MoreThanHalfCouncil;
+	type RemoveOrigin = MoreThanHalfCouncil;
+	type ResetOrigin = MoreThanHalfCouncil;


This looks like it should be either unanimous or the same as the above ones.

al3mart · 2025-01-24T14:06:07Z

runtime/mainnet/src/config/governance.rs

+	type RemoveOrigin = MoreThanHalfCouncil;
+	type ResetOrigin = MoreThanHalfCouncil;
+	type RuntimeEvent = RuntimeEvent;
+	type SwapOrigin = MoreThanHalfCouncil;


Super majority or a ratio equivalent to all votes in favor but one seems to fit this origin.

peterwht · 2025-01-27T21:56:14Z

[sc-2200]

AlexD10S · 2025-01-30T14:21:26Z

The step-by-step guide in the PR description is great. I've been testing and looks good 👌

peterwht added 5 commits January 23, 2025 08:39

feat(pallets): add pallet-motion

ba4ff95

build(mainnet): add gov pallets: collective, membership, motion

fd0be06

feat(mainnet): add gov configs: collective, membership, motion

144e172

feat(node): add councillors at genesis

a71b621

TEMPORARY COMMIT: Sets mainnet chain-spec to Development

0af0165

peterwht commented Jan 23, 2025

View reviewed changes

al3mart reviewed Jan 24, 2025

View reviewed changes

peterwht changed the base branch from main to al3mart/refactor-mainnet-governance January 24, 2025 17:44

peterwht changed the base branch from al3mart/refactor-mainnet-governance to main January 24, 2025 17:44

al3mart mentioned this pull request Jan 31, 2025

refactor(mainnet): ready runtime config #458

Draft

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(mainnet): add gov: collective, membership, motion #448

feat(mainnet): add gov: collective, membership, motion #448

peterwht commented Jan 23, 2025 •

edited

Loading

peterwht Jan 23, 2025

peterwht Jan 23, 2025 •

edited

Loading

peterwht Jan 23, 2025

al3mart Jan 24, 2025

peterwht commented Jan 23, 2025

al3mart commented Jan 24, 2025 •

edited

Loading

al3mart left a comment

al3mart Jan 24, 2025

al3mart Jan 24, 2025

al3mart Jan 24, 2025

al3mart Jan 24, 2025

al3mart Jan 24, 2025

peterwht commented Jan 27, 2025

AlexD10S commented Jan 30, 2025

feat(mainnet): add gov: collective, membership, motion #448

Are you sure you want to change the base?

feat(mainnet): add gov: collective, membership, motion #448

Conversation

peterwht commented Jan 23, 2025 • edited Loading

Guide

Goal Checklist

Create a Motion that requires Root

Create a Motion that adds a member

Create a Motion that removes a member

Notes

Choose a reason for hiding this comment

peterwht Jan 23, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

peterwht commented Jan 23, 2025

al3mart commented Jan 24, 2025 • edited Loading

al3mart left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

peterwht commented Jan 27, 2025

AlexD10S commented Jan 30, 2025

peterwht commented Jan 23, 2025 •

edited

Loading

peterwht Jan 23, 2025 •

edited

Loading

al3mart commented Jan 24, 2025 •

edited

Loading