Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-release #102

Merged
merged 24 commits into from
Feb 17, 2025
Merged

pre-release #102

merged 24 commits into from
Feb 17, 2025

Conversation

kalimu
Copy link
Member

@kalimu kalimu commented Feb 13, 2025

Closes #34 #90 #94

@kalimu kalimu requested a review from maciekbanas February 13, 2025 15:37
Copy link
Member

@maciekbanas maciekbanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review finished. Some typos, one question (can be converted into issue).
CI/CD do not pass because of error when downloading shinychat. Is there any reason why we do not use CRAN version?

image

)")

ellmer:::chat_perform_value
custom_function <- function(provider, req) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a question: I wonder if we should not somehow document this workaround, till ellmer itself addresses the time out issue.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I belive I've described this in the vignette. If not good enough please feel free to fix it.

.package = "ellmer"
)

# my_project <- my_project |> set_llm(provider = "bedrock")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why commented code in tests? Lint check will not pass.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test fails after updating ellmer. Feel free to remove, as I'm not sure how to fix it now. Probably we could simplify those test stubs in the future.

kalimu and others added 6 commits February 14, 2025 09:24
Co-authored-by: Maciej Banaś <[email protected]>
Co-authored-by: Maciej Banaś <[email protected]>
Co-authored-by: Maciej Banaś <[email protected]>
Co-authored-by: Maciej Banaś <[email protected]>
Co-authored-by: Maciej Banaś <[email protected]>
Co-authored-by: Maciej Banaś <[email protected]>
@kalimu
Copy link
Member Author

kalimu commented Feb 14, 2025

Review finished. Some typos, one question (can be converted into issue). CI/CD do not pass because of error when downloading shinychat. Is there any reason why we do not use CRAN version?

Definitely we should use the CRAN version. I think I needed the higher shinychat version which wasn't on CRAN yet. Feel free to fix it.

Copy link
Member Author

@kalimu kalimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for correcting those typos!

@maciekbanas maciekbanas merged commit 2444c04 into main Feb 17, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prepare the first release with minimal workflow
2 participants