-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pre-release #102
pre-release #102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
)") | ||
|
||
ellmer:::chat_perform_value | ||
custom_function <- function(provider, req) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a question: I wonder if we should not somehow document this workaround, till ellmer
itself addresses the time out issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I belive I've described this in the vignette. If not good enough please feel free to fix it.
tests/testthat/test-set_llm.R
Outdated
.package = "ellmer" | ||
) | ||
|
||
# my_project <- my_project |> set_llm(provider = "bedrock") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why commented code in tests? Lint
check will not pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test fails after updating ellmer. Feel free to remove, as I'm not sure how to fix it now. Probably we could simplify those test stubs in the future.
Co-authored-by: Maciej Banaś <[email protected]>
Co-authored-by: Maciej Banaś <[email protected]>
Co-authored-by: Maciej Banaś <[email protected]>
Co-authored-by: Maciej Banaś <[email protected]>
Co-authored-by: Maciej Banaś <[email protected]>
Co-authored-by: Maciej Banaś <[email protected]>
Definitely we should use the CRAN version. I think I needed the higher shinychat version which wasn't on CRAN yet. Feel free to fix it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for correcting those typos!
…talling 3.6.4 from CRAN (yesterday released).
Closes #34 #90 #94