-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added option to get decimal point in uncertainty formatted with "parenthesis" notation #60
Conversation
…h "parenthesis" notation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #60 +/- ##
==========================================
- Coverage 97.28% 96.60% -0.69%
==========================================
Files 12 12
Lines 516 530 +14
==========================================
+ Hits 502 512 +10
- Misses 14 18 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for this. I see that some of the changes that I did in the last commits have been undone for some reason. Please restore them. Comments below.
Sorry for the changes, I should have checked more carefully. I was merging from an older revision I did. Part of the changes were related to using meld with omission of whitespace diffs. I have now applied all requested changes, committed and pushed to github. As far as I understand, that should be enough, please let me know if I also need to resubmit the pull request. |
Thanks! I renamed (and shortened) the new option, and added a new argument |
No problem! I am not an expert of pull requests and have not realized that a push permission was asked or required. |
It is not required, but it is convenient when, like in this case, the owner of the repo wants to add some adjustments to the PR. |
Hi,
I propose a small unobstructive addition to the code in order to optionally get the decimal point formatted when using the "parenthesis" notation. Example of usage: