Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New if_switch_linter #2304

Merged
merged 9 commits into from
Nov 20, 2023
Merged

New if_switch_linter #2304

merged 9 commits into from
Nov 20, 2023

Conversation

MichaelChirico
Copy link
Collaborator

Part of #884

No hits on {lintr}

@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ff1dc21) 99.38% compared to head (b0652e0) 99.39%.

❗ Current head b0652e0 differs from pull request most recent head 4ec39b4. Consider uploading reports for the commit 4ec39b4 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2304   +/-   ##
=======================================
  Coverage   99.38%   99.39%           
=======================================
  Files         119      120    +1     
  Lines        5392     5418   +26     
=======================================
+ Hits         5359     5385   +26     
  Misses         33       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@AshesITR AshesITR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing metadata and vectorization tests.

inst/lintr/linters.csv Outdated Show resolved Hide resolved
R/if_switch_linter.R Outdated Show resolved Hide resolved
@MichaelChirico MichaelChirico merged commit 0815b2a into main Nov 20, 2023
20 checks passed
@MichaelChirico MichaelChirico deleted the if_switch branch November 20, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants