Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test causing a warning in the lint GHA #2290

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Conversation

MichaelChirico
Copy link
Collaborator

@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fa9e1bf) 99.64% compared to head (02fe004) 99.64%.

❗ Current head 02fe004 differs from pull request most recent head d9782e2. Consider uploading reports for the commit d9782e2 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2290   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files         115      115           
  Lines        5284     5284           
=======================================
  Hits         5265     5265           
  Misses         19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am surprised that this warning wasn't turned into an error in the vigilant workflow?

@MichaelChirico
Copy link
Collaborator Author

I am surprised that this warning wasn't turned into an error in the vigilant workflow?

it's thrown by lint_package(), not test_check()

@MichaelChirico MichaelChirico merged commit 90f105e into main Nov 16, 2023
19 of 20 checks passed
@MichaelChirico MichaelChirico deleted the one_linter_test branch November 16, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants