Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to cli style #2277

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Switch to cli style #2277

merged 2 commits into from
Nov 17, 2023

Conversation

MichaelChirico
Copy link
Collaborator

Closes #2220

@IndrajeetPatil do you know if we need to change these options in the workflows?

options(crayon.enabled = TRUE, warn = 2L)

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9140487) 99.64% compared to head (897e768) 99.64%.

❗ Current head 897e768 differs from pull request most recent head 7f99295. Consider uploading reports for the commit 7f99295 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2277   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files         115      115           
  Lines        5286     5286           
=======================================
  Hits         5267     5267           
  Misses         19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AshesITR
Copy link
Collaborator

Closes #2220

@IndrajeetPatil do you know if we need to change these options in the workflows?

options(crayon.enabled = TRUE, warn = 2L)

https://github.com/r-lib/cli/blob/main/vignettes/cli-config-internal.Rmd

Says it's deprecated. cli.num_colors = 8L seems to be the preferred way currently, looking at the code of num_ansi_colors().
It should work without adjustment for the moment, though.

@MichaelChirico
Copy link
Collaborator Author

It looks like it's really supposed to "just work" with {cli}. I would guess GHA is one use case that's gotten a lot of attention too... let's try disabling the options for now.

@IndrajeetPatil
Copy link
Collaborator

AFAICT, the crayon.enabled = TRUE is relevant only for printing the workflow output in color, which is what we want. So we don't need to change anything here for the workflows.

Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@MichaelChirico MichaelChirico merged commit 3e7bb47 into main Nov 17, 2023
20 checks passed
@MichaelChirico MichaelChirico deleted the crayon-cli branch November 17, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use {cli}, not {crayon}
4 participants