Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more precise #2268

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Be more precise #2268

merged 1 commit into from
Nov 10, 2023

Conversation

salim-b
Copy link
Contributor

@salim-b salim-b commented Nov 10, 2023

requireNamespace("pkg") does load pkg, but not attach it.

`requireNamespace("pkg")` does *load* pkg, but not *attach* it.
@codecov-commenter
Copy link

Codecov Report

Merging #2268 (3b1224a) into main (afd88d7) will not change coverage.
The diff coverage is n/a.

❗ Current head 3b1224a differs from pull request most recent head 651f107. Consider uploading reports for the commit 651f107 to get more accurate results

@@           Coverage Diff           @@
##             main    #2268   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files         114      114           
  Lines        5235     5235           
=======================================
  Hits         5216     5216           
  Misses         19       19           
Files Coverage Δ
R/unused_import_linter.R 100.00% <ø> (ø)

Copy link
Collaborator

@MichaelChirico MichaelChirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, thanks!

@MichaelChirico MichaelChirico merged commit 5edcfaa into r-lib:main Nov 10, 2023
20 checks passed
@salim-b salim-b deleted the patch-1 branch November 10, 2023 03:10
@salim-b salim-b mentioned this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants