Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend conjunct_test_linter for dplyr::filter() #2077

Merged
merged 6 commits into from
Aug 14, 2023
Merged

extend conjunct_test_linter for dplyr::filter() #2077

merged 6 commits into from
Aug 14, 2023

Conversation

MichaelChirico
Copy link
Collaborator

@MichaelChirico MichaelChirico commented Aug 10, 2023

Closes #2073, part of #884

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2023

Codecov Report

Merging #2077 (f9ef06a) into main (3680289) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head f9ef06a differs from pull request most recent head 129c9aa. Consider uploading reports for the commit 129c9aa to get more accurate results

@@           Coverage Diff           @@
##             main    #2077   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files         117      117           
  Lines        5117     5124    +7     
=======================================
+ Hits         5099     5106    +7     
  Misses         18       18           
Files Changed Coverage Δ
R/conjunct_test_linter.R 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@MichaelChirico
Copy link
Collaborator Author

Marking the stats::filter() issue for follow-up: #2078

R/conjunct_test_linter.R Show resolved Hide resolved
R/conjunct_test_linter.R Show resolved Hide resolved
AshesITR
AshesITR previously approved these changes Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

filter_and: New linter, or part of conjunct_test_linter()?
3 participants