Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file path detection in paste_linter #2074

Merged
merged 9 commits into from
Aug 11, 2023
Merged

file path detection in paste_linter #2074

merged 9 commits into from
Aug 11, 2023

Conversation

MichaelChirico
Copy link
Collaborator

@MichaelChirico MichaelChirico commented Aug 10, 2023

Part of #884 and #1108. We wrote this as a separate PasteFilePathLinter(), but I believe it fits well as an extension of paste_linter().

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2023

Codecov Report

Merging #2074 (0c5dc5d) into main (781a18d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 0c5dc5d differs from pull request most recent head a1bc413. Consider uploading reports for the commit a1bc413 to get more accurate results

@@           Coverage Diff           @@
##             main    #2074   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files         117      117           
  Lines        5038     5106   +68     
=======================================
+ Hits         5020     5088   +68     
  Misses         18       18           
Files Changed Coverage Δ
R/methods.R 100.00% <100.00%> (ø)
R/paste_linter.R 100.00% <100.00%> (ø)
R/xp_utils.R 100.00% <100.00%> (ø)

R/paste_linter.R Show resolved Hide resolved
R/paste_linter.R Show resolved Hide resolved
R/paste_linter.R Outdated Show resolved Hide resolved
R/paste_linter.R Show resolved Hide resolved
tests/testthat/test-paste_linter.R Show resolved Hide resolved
R/xp_utils.R Show resolved Hide resolved
@AshesITR AshesITR merged commit 0e3eb9d into main Aug 11, 2023
@AshesITR AshesITR deleted the paste-file-path branch August 11, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants